Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(op bunching) Deprecate process on FluidDataStoreRuntime #23866

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

agarwal-navin
Copy link
Contributor

Deprecating process on FluidDataStoreRuntime. It was deprecated on IFluidDataStoreChannel (and other places) as part of #22840 but missed deprecating it on FluidDataStoreRuntime.

@Copilot Copilot bot review requested due to automatic review settings February 18, 2025 19:10
@agarwal-navin agarwal-navin requested a review from a team as a code owner February 18, 2025 19:10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

packages/runtime/datastore/src/dataStoreRuntime.ts:797

  • The default case in the switch statement should handle unrecognized message types to avoid silent failures. Consider adding a log or throwing an error.
default:
@github-actions github-actions bot added area: runtime Runtime related issues changeset-present base: main PRs targeted against main branch labels Feb 18, 2025
@agarwal-navin agarwal-navin requested a review from a team as a code owner February 18, 2025 20:24
@github-actions github-actions bot added the public api change Changes to a public API label Feb 18, 2025
"@fluidframework/datastore": minor
---
---
"section": deprecation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not saying this is necessarily correct but I wonder if we should put it in the section for changes to the legacy API since that's where FluidDataStoreRuntime lives. cc @tylerbutler and @jason-ha for thoughts. I know we used deprecation in the previous change so maybe that's reason enough to have it match here, but at least wanted to bring it up for discussion which might affect future deprecations of legacy APIs.

Suggested change
"section": deprecation
"section": legacy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong feeling either way. For now, I am keeping it deprecation to be in line with the previous change like you said.

Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  160781 links
    1452 destination URLs
    1683 URLs ignored
       0 warnings
       0 errors


Copy link
Member

@tylerbutler tylerbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge only to help with release race-conditions. I'll remove this block once release branch is created.

@tylerbutler tylerbutler dismissed their stale review February 20, 2025 05:49

Release is unblocked.

Copy link
Contributor

@noencke noencke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API Approval

@agarwal-navin agarwal-navin requested a review from a team February 20, 2025 23:03
@agarwal-navin agarwal-navin merged commit 3f44d43 into microsoft:main Feb 21, 2025
47 checks passed
@agarwal-navin agarwal-navin deleted the deprecateProcess2 branch February 21, 2025 00:17
tylerbutler pushed a commit to tylerbutler/FluidFramework that referenced this pull request Feb 22, 2025
…3866)

Deprecating `process` on `FluidDataStoreRuntime`. It was deprecated on
`IFluidDataStoreChannel` (and other places) as part of
microsoft#22840 but missed
deprecating it on `FluidDataStoreRuntime`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues base: main PRs targeted against main branch changeset-present public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants