Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted Follow up to add nav parameter #23873

Merged
merged 19 commits into from
Feb 19, 2025

Conversation

MarioJGMsoft
Copy link
Contributor

Description

This change needs to be reverted for now and will me merged for next release

@github-actions github-actions bot added area: driver Driver related issues area: odsp-driver base: main PRs targeted against main branch labels Feb 19, 2025
@MarioJGMsoft MarioJGMsoft marked this pull request as ready for review February 19, 2025 00:54
@Copilot Copilot bot review requested due to automatic review settings February 19, 2025 00:54

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@MarioJGMsoft MarioJGMsoft requested a review from a team as a code owner February 19, 2025 01:03
@github-actions github-actions bot added the public api change Changes to a public API label Feb 19, 2025
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  160781 links
    1452 destination URLs
    1683 URLs ignored
       0 warnings
       0 errors


@MarioJGMsoft MarioJGMsoft merged commit dad284d into microsoft:main Feb 19, 2025
35 checks passed
tylerbutler pushed a commit to tylerbutler/FluidFramework that referenced this pull request Feb 22, 2025
## Description

This change needs to be reverted for now and will me merged for next
release

---------

Co-authored-by: Jatin Garg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues area: odsp-driver base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants