Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting change due to Fluid-Loop pipeline integration failure. #23874

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Reverting change due to Fluid-Loop pipeline integration failure. #23874

merged 2 commits into from
Feb 19, 2025

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Feb 19, 2025

Description

Reverting change due to Fluid-Loop pipeline integration failure..
This PR: b17276c caused Fluid loop integration pipeline to fail: https://office.visualstudio.com/OC/_build?definitionId=29163&_a=summary

@jatgarg jatgarg requested review from Copilot, WayneFerrao and anthony-murphy and removed request for Copilot February 19, 2025 00:56
@github-actions github-actions bot added area: build Build related issues area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dds: tree area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Feb 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  160781 links
    1452 destination URLs
    1683 URLs ignored
       0 warnings
       0 errors

chentong7
chentong7 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@chentong7 chentong7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogogo

@jatgarg jatgarg merged commit ffab747 into microsoft:main Feb 19, 2025
41 checks passed
jatgarg pushed a commit to jatgarg/FluidFramework-1 that referenced this pull request Feb 19, 2025
Revert "Reverting change due to Fluid-Loop pipeline integration failu…
ebe4a5d 
…re. (microsoft#23874)"

This reverts commit ffab747.
@jatgarg jatgarg mentioned this pull request Feb 19, 2025
Merged
jatgarg added a commit that referenced this pull request Feb 19, 2025
@jatgarg
Revert "Reverting change due to Fluid-Loop pipeline integration failu…
0787c9e 
…re. (#23874)" (#23876)

## Description

Revert "Reverting change due to Fluid-Loop pipeline integration failure.
(#23874) because some unwanted changes got pushed with the revert.

Co-authored-by: Jatin Garg <[email protected]>
@jatgarg jatgarg deleted the revert branch February 19, 2025 22:57
tylerbutler pushed a commit to tylerbutler/FluidFramework that referenced this pull request Feb 22, 2025
@jatgarg
Reverting change due to Fluid-Loop pipeline integration failure. (mic…
46bbbd2 
…rosoft#23874)

## Description

Reverting change due to Fluid-Loop pipeline integration failure..
This PR:
microsoft@b17276c
caused Fluid loop integration pipeline to fail:
https://office.visualstudio.com/OC/_build?definitionId=29163&_a=summary

---------

Co-authored-by: Jatin Garg <[email protected]>
tylerbutler pushed a commit to tylerbutler/FluidFramework that referenced this pull request Feb 22, 2025
@jatgarg
Revert "Reverting change due to Fluid-Loop pipeline integration failu…
36ad605 
…re. (microsoft#23874)" (microsoft#23876)

## Description

Revert "Reverting change due to Fluid-Loop pipeline integration failure.
(microsoft#23874) because some unwanted changes got pushed with the revert.

Co-authored-by: Jatin Garg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chentong7 chentong7 chentong7 approved these changes

@WayneFerrao WayneFerrao Awaiting requested review from WayneFerrao

@anthony-murphy anthony-murphy Awaiting requested review from anthony-murphy

Assignees
No one assigned
Labels
area: build Build related issues area: dds: propertydds area: dds: sharedstring area: dds: tree area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jatgarg @chentong7