Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(client): Update typetests after minor release 2.22.0 #23894

Merged
merged 7 commits into from
Feb 20, 2025

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Feb 20, 2025

build(client): Update typetests after minor release 2.12.0

@jatgarg jatgarg self-assigned this Feb 20, 2025
@Copilot Copilot bot review requested due to automatic review settings February 20, 2025 19:01
@jatgarg jatgarg requested review from a team as code owners February 20, 2025 19:01
@github-actions github-actions bot added area: build Build related issues area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dds: tree area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc changeset-present base: main PRs targeted against main branch dependencies Pull requests that update a dependency file labels Feb 20, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 217 out of 217 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

.changeset/smart-emus-look.md:5

  • An additional YAML separator is detected in the changeset file. Consider combining the metadata into a single front matter block for clarity.
+---

@alexvy86
Copy link
Contributor

I think the changes are from a wrong branch? This is... bringing back changesets and removing changelog entries?

Copy link
Contributor

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

http://localhost:3000/docs/data-structures/tree
- (36:97) 'the Shar..' => http://localhost:3000/docs/api/tree (HTTP 404)

http://localhost:3000/docs/data-structures/tree/
- (36:97) 'the Shar..' => http://localhost:3000/docs/api/tree (HTTP 404)

http://localhost:3000/docs/data-structures/tree/schema-definition
- (30:128) 'SharedTr..' => http://localhost:3000/docs/api/tree (HTTP 404)

http://localhost:3000/docs/start/tree-start
- (44:4) 'the API ..' => http://localhost:3000/docs/api/tree/schemafactory-class (HTTP 404)
- (61:7) 'the API' => http://localhost:3000/docs/api/tree/treechangeevents-interface (HTTP 404)


Stats:
  158264 links
    1304 destination URLs
    1535 URLs ignored
       0 warnings
       3 errors

 ELIFECYCLE  Command failed with exit code 1.

@github-actions github-actions bot removed area: build Build related issues area: examples Changes that focus on our examples area: dds: propertydds changeset-present area: dev experience Improving the experience of devs building on top of fluid labels Feb 20, 2025
Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for devtools. Looks good to me overall though.

Copy link
Member

@tylerbutler tylerbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once CI passes.

@jatgarg jatgarg merged commit 11b06b7 into microsoft:main Feb 20, 2025
35 checks passed
@jatgarg jatgarg deleted the typetmain branch February 20, 2025 20:33
tylerbutler pushed a commit to tylerbutler/FluidFramework that referenced this pull request Feb 22, 2025
…#23894)

build(client): Update typetests after minor release 2.12.0

---------

Co-authored-by: Jatin Garg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: sharedstring area: dds: tree area: dds Issues related to distributed data structures area: driver Driver related issues area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants