-
Notifications
You must be signed in to change notification settings - Fork 559
build: remove all tslint references from codebase #25998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Remove TsLintTask class from build-tools lintTasks.ts - Remove tslint entry from taskFactory.ts executable map - Update build-tools README.md to remove tslint references - Remove $tslint5 problem matcher from .vscode/tasks.json files - Remove tslint:disable comments from basicRestwrapper.spec.ts - Remove tslint dev dependency and script from historian packages - Update historian pnpm-lock.yaml after removing tslint Co-authored-by: tylerbutler <[email protected]>
|
/azp run Build - protocol-definitions,Build - test-tools,server-gitrest,server-gitssh,server-routerlicious,Build - client packages,repo-policy-check,Build - build-tools |
|
/azp run Build - api-markdown-documenter,Build - benchmark-tool,Build - build-common,Build - build-tools,Build - common-utils,Build - eslint-config-fluid,Build - eslint-plugin-fluid,server-historian |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
1 similar comment
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
@copilot merge the latest main branch and address the merge conflict in lintTasks.ts. DO NOT REBASE! |
- Keep new EsLintTask functionality from main (shared config tracking) - Remove TsLintTask class as part of tslint removal Co-authored-by: tylerbutler <[email protected]>
|
@copilot You did not make a proper merge commit. Revert the last commit, then MERGE the latest main branch. DO NOT REBASE. |
Co-authored-by: tylerbutler <[email protected]>
Reverts commits 550a4f8 and e4510b0 which were not proper merge commits. Co-authored-by: tylerbutler <[email protected]>
…to copilot/remove-tslint-references # Conflicts: # build-tools/packages/build-tools/src/fluidBuild/tasks/leaf/lintTasks.ts
|
/azp run Build - protocol-definitions,Build - test-tools,server-gitrest,server-gitssh,server-routerlicious,Build - client packages,repo-policy-check,Build - build-tools |
|
/azp run Build - api-markdown-documenter,Build - benchmark-tool,Build - build-common,Build - build-tools,Build - common-utils,Build - eslint-config-fluid,Build - eslint-plugin-fluid,server-historian |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Azure Pipelines successfully started running 4 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes all remaining tslint references from the codebase following the historical migration to eslint. The cleanup spans build tools, server packages, test files, VSCode configuration, and documentation.
- Removes build tool support for tslint tasks
- Removes tslint dependencies from historian server packages
- Removes 34 obsolete tslint disable comments from test files
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
server/routerlicious/packages/services-client/src/test/basicRestwrapper.spec.ts |
Removes 34 // tslint:disable-next-line comments from test assertions |
server/historian/pnpm-lock.yaml |
Removes tslint and its dependencies (builtin-modules, [email protected], tsutils), marks orphaned transitive dependencies as optional |
server/historian/packages/historian/package.json |
Removes tslint dev dependency and tslint script |
server/historian/package.json |
Removes tslint dev dependency from root historian package |
packages/test/test-end-to-end-tests/.vscode/tasks.json |
Removes $tslint5 problem matcher from VSCode task configuration |
build-tools/packages/build-tools/src/fluidBuild/tasks/taskFactory.ts |
Removes tslint entry from executableToLeafTask map and removes TsLintTask import |
build-tools/packages/build-tools/src/fluidBuild/tasks/leaf/lintTasks.ts |
Removes entire TsLintTask class implementation |
build-tools/packages/build-tools/README.md |
Updates documentation to remove tslint references from task descriptions |
.vscode/tasks.json |
Removes $tslint5 problem matcher from two task configurations |
Files not reviewed (1)
- server/historian/pnpm-lock.yaml: Language not supported
|
/azp run Build - protocol-definitions,Build - test-tools,server-gitrest,server-gitssh,server-routerlicious,Build - client packages,repo-policy-check,Build - build-tools |
|
/azp run Build - api-markdown-documenter,Build - benchmark-tool,Build - build-common,Build - build-tools,Build - common-utils,Build - eslint-config-fluid,Build - eslint-plugin-fluid,server-historian |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Description
Removes all tslint references since the project migrated to eslint long ago.
Build tools:
TsLintTaskclass fromlintTasks.tstslintfromexecutableToLeafTaskmap intaskFactory.tsVSCode configuration:
$tslint5problem matcher from.vscode/tasks.jsonfilesServer/historian:
tslintdev dependency and script from package.json filespnpm-lock.yamlTest cleanup:
// tslint:disable-next-linecomments frombasicRestwrapper.spec.tsNote:
@typescript-eslint/ban-tslint-commentreferences in eslint-config-fluid are retained—these are eslint rules that enforce the tslint→eslint migration.Reviewer Guidance
Straightforward removal. Build-tools and historian packages compile and tests pass.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.