Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 8, 2025

Description

Removes all tslint references since the project migrated to eslint long ago.

Build tools:

  • Remove TsLintTask class from lintTasks.ts
  • Remove tslint from executableToLeafTask map in taskFactory.ts
  • Update README to remove tslint documentation

VSCode configuration:

  • Remove $tslint5 problem matcher from .vscode/tasks.json files

Server/historian:

  • Remove tslint dev dependency and script from package.json files
  • Regenerate pnpm-lock.yaml

Test cleanup:

  • Remove 34 // tslint:disable-next-line comments from basicRestwrapper.spec.ts

Note: @typescript-eslint/ban-tslint-comment references in eslint-config-fluid are retained—these are eslint rules that enforce the tslint→eslint migration.

Reviewer Guidance

Straightforward removal. Build-tools and historian packages compile and tests pass.

Original prompt

We have long since migrated to eslint from tslint, so remove all references to tslint, including task support in build tools, disable comments, etc.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Remove TsLintTask class from build-tools lintTasks.ts
- Remove tslint entry from taskFactory.ts executable map
- Update build-tools README.md to remove tslint references
- Remove $tslint5 problem matcher from .vscode/tasks.json files
- Remove tslint:disable comments from basicRestwrapper.spec.ts
- Remove tslint dev dependency and script from historian packages
- Update historian pnpm-lock.yaml after removing tslint

Co-authored-by: tylerbutler <[email protected]>
Copilot AI changed the title [WIP] Remove all references to tslint from the project Remove all tslint references from codebase Dec 8, 2025
Copilot AI requested a review from tylerbutler December 8, 2025 20:08
@tylerbutler
Copy link
Member

/azp run Build - protocol-definitions,Build - test-tools,server-gitrest,server-gitssh,server-routerlicious,Build - client packages,repo-policy-check,Build - build-tools

@tylerbutler
Copy link
Member

/azp run Build - api-markdown-documenter,Build - benchmark-tool,Build - build-common,Build - build-tools,Build - common-utils,Build - eslint-config-fluid,Build - eslint-plugin-fluid,server-historian

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@tylerbutler
Copy link
Member

@copilot merge the latest main branch and address the merge conflict in lintTasks.ts. DO NOT REBASE!

- Keep new EsLintTask functionality from main (shared config tracking)
- Remove TsLintTask class as part of tslint removal

Co-authored-by: tylerbutler <[email protected]>
Copy link
Contributor Author

Copilot AI commented Dec 10, 2025

@copilot merge the latest main branch and address the merge conflict in lintTasks.ts. DO NOT REBASE!

Merged main and resolved the conflict in lintTasks.ts in commit e4510b0. Kept the new EsLintTask functionality from main (shared config tracking) while removing the TsLintTask class.

@tylerbutler
Copy link
Member

@copilot You did not make a proper merge commit. Revert the last commit, then MERGE the latest main branch. DO NOT REBASE.

Copilot AI and others added 3 commits December 10, 2025 20:58
Reverts commits 550a4f8 and e4510b0 which were not proper merge commits.

Co-authored-by: tylerbutler <[email protected]>
…to copilot/remove-tslint-references

# Conflicts:
#	build-tools/packages/build-tools/src/fluidBuild/tasks/leaf/lintTasks.ts
Copy link
Contributor Author

Copilot AI commented Dec 10, 2025

@copilot You did not make a proper merge commit. Revert the last commit, then MERGE the latest main branch. DO NOT REBASE.

Reverted the bad commits in 8d47650 and created a proper merge commit with two parents in cc2259c.

@tylerbutler tylerbutler changed the title Remove all tslint references from codebase build: remove all tslint references from codebase Dec 10, 2025
@tylerbutler
Copy link
Member

/azp run Build - protocol-definitions,Build - test-tools,server-gitrest,server-gitssh,server-routerlicious,Build - client packages,repo-policy-check,Build - build-tools

@tylerbutler
Copy link
Member

/azp run Build - api-markdown-documenter,Build - benchmark-tool,Build - build-common,Build - build-tools,Build - common-utils,Build - eslint-config-fluid,Build - eslint-plugin-fluid,server-historian

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tylerbutler tylerbutler marked this pull request as ready for review December 10, 2025 21:17
Copilot AI review requested due to automatic review settings December 10, 2025 21:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes all remaining tslint references from the codebase following the historical migration to eslint. The cleanup spans build tools, server packages, test files, VSCode configuration, and documentation.

  • Removes build tool support for tslint tasks
  • Removes tslint dependencies from historian server packages
  • Removes 34 obsolete tslint disable comments from test files

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
server/routerlicious/packages/services-client/src/test/basicRestwrapper.spec.ts Removes 34 // tslint:disable-next-line comments from test assertions
server/historian/pnpm-lock.yaml Removes tslint and its dependencies (builtin-modules, [email protected], tsutils), marks orphaned transitive dependencies as optional
server/historian/packages/historian/package.json Removes tslint dev dependency and tslint script
server/historian/package.json Removes tslint dev dependency from root historian package
packages/test/test-end-to-end-tests/.vscode/tasks.json Removes $tslint5 problem matcher from VSCode task configuration
build-tools/packages/build-tools/src/fluidBuild/tasks/taskFactory.ts Removes tslint entry from executableToLeafTask map and removes TsLintTask import
build-tools/packages/build-tools/src/fluidBuild/tasks/leaf/lintTasks.ts Removes entire TsLintTask class implementation
build-tools/packages/build-tools/README.md Updates documentation to remove tslint references from task descriptions
.vscode/tasks.json Removes $tslint5 problem matcher from two task configurations
Files not reviewed (1)
  • server/historian/pnpm-lock.yaml: Language not supported

@tylerbutler
Copy link
Member

/azp run Build - protocol-definitions,Build - test-tools,server-gitrest,server-gitssh,server-routerlicious,Build - client packages,repo-policy-check,Build - build-tools

@tylerbutler
Copy link
Member

/azp run Build - api-markdown-documenter,Build - benchmark-tool,Build - build-common,Build - build-tools,Build - common-utils,Build - eslint-config-fluid,Build - eslint-plugin-fluid,server-historian

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants