Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: rename the video name when test device count is 1 #659

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

zhou9584
Copy link
Contributor

@zhou9584 zhou9584 commented Jun 24, 2024

Description

Linked GitHub issue ID:

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

@zhou9584 zhou9584 enabled auto-merge (squash) March 3, 2025 09:19
@zhou9584
Copy link
Contributor Author

zhou9584 commented Mar 3, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zhou9584 zhou9584 merged commit ebcb1cc into main Mar 3, 2025
5 checks passed
@zhou9584 zhou9584 deleted the zhoule/fixVideoNameBug branch March 3, 2025 10:08
@dj3500
Copy link

dj3500 commented Mar 3, 2025

Again, a heads-up that you guys have mistakenly subscribed a lot of Microsoft folks to this repo. Would be fantastic to undo it, rather than have everyone either need to go and unsubscribe themselves, or receive 20 junk emails per day.

@shklar
Copy link

shklar commented Mar 4, 2025 via email

@hydraxman
Copy link
Member

Again, a heads-up that you guys have mistakenly subscribed a lot of Microsoft folks to this repo. Would be fantastic to undo it, rather than have everyone either need to go and unsubscribe themselves, or receive 20 junk emails per day.

We didn't have a clue why this is happening yet. Will talk to other owners why this is happening. Think I've experienced such thing for other github MS repo. This is not what we intended. You can go to https://github.com/microsoft/HydraLab, and hit unwatch, you will opt out from this.
image

@0b01
Copy link

0b01 commented Mar 4, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants