Rebase to remove invalid auth_token #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing old method of testing + adding in karma test runner for more modern cli testing. Improving code coverage to include testing for browser + sharedworker+ webworker for nosqlprovider
* Downgraded tsconfig output to ES5, and did package upgrades Package upgrades: upgraded webpack-cl and ts-loader to remove warnings Also, moved @types/lodash and ts-loader to dev-deps * ci: version bump to 0.6.27 * ci: version bump to 0.6.28 Co-authored-by: Thomas Tay <[email protected]> Co-authored-by: Automated Version Bump <[email protected]>
1. Updated the CI build to automatically publish packages to npm feed 2. Added the recommended files from Microsoft 3. Added license headers to every source file Co-authored-by: Thomas Tay <[email protected]>
…ions (#27) Added unit tests for the B Tree, this is located in SortedBTree.spec.ts Added a test generator that can detect errors in the sorted-btree library through random testing. In fact, this test generator is what generated the unit tests. If there are future errors, the test generator can create additional unit tests to prevent regressions. Details are in the README in the folder. We will run both of them as part of the usual test suite. Other things: 3. Updated the PR build to not generate tags (this was causing problem if we have multiple PRs in flight) 4. Export the OrderedMapType as a type, so we can use it in TMP Co-authored-by: Thomas Tay <[email protected]>
Co-authored-by: Thomas Tay <[email protected]>
This reverts commit 9177279.
|
Do you know why the commits here look out of order? |
Here's the commit history of 
This PR won't have two commits marked in green. We can see the history appearing in this PR starting with commit marked in red, in the same order. Not sure what you mean by "out of order".
Yes, will delete those commits and the commit history from that point onwards will be modified. |
|
can you check that the tests build with your current changes |
|
run |
Yes, succeeds in PR build: https://github.com/microsoft/ObjectStoreProvider/actions/runs/10374350179/job/28721557970?pr=58 |
eliranek1
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO WI: https://msrceng.visualstudio.com/VulnReports/_workitems/edit/216726
We have 2 commits in
masterbranch which has auth_token exposed:5e12453
93b2337
These tokens are invalidated and we also need to remove the commits (that added these tokens) from commit history.
Here's a PR which is rebased to remove the commits from commit history. (I don't think I have access to force push to
masterbranch, so here's the PR)We can see that commits which had auth_token exposed in npmrc doesn't exist in this branch:
https://github.com/microsoft/ObjectStoreProvider/commits/user/bviswanathan/remove_auth_token/.npmrc