moduleSpecifiers: Simpler criteria for preferring relative path vs baseUrl #25803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode#52485
Previously we were just checking if
relativePath
climbed all the way up to baseUrl. But in a case where we have/src/d0/d1/d2/d3/d4/d5/user.ts
importing fromsrc/d0/a.ts
, it was only climbing up most of the way to baseUrl.pathFromSourceToBaseUrl
grew just as fast asrelativePath
and we never switched over to using baseUrl.New criteria is to just count the number of components in each path.