Skip to content

Add inference priority level for conditional types in contravariant positions #35199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 21, 2019
Merged

Add inference priority level for conditional types in contravariant positions #35199

merged 4 commits into from
Nov 21, 2019

Conversation

ahejlsberg
Copy link
Member

Fixes #33568.

@ahejlsberg
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 19, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 991d83e. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 19, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 991d83e. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 19, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 991d83e. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot typescript-bot mentioned this pull request Nov 19, 2019
Closed
@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@ahejlsberg
Copy link
Member Author

RWC, DT, and Community Tests all look good (errors are the usual preexisting conditions).

weswigham
weswigham approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have reasoning for why inferences made at this priority are better than return type inferences?

@ahejlsberg
Copy link
Member Author

@weswigham No particular reason other than we always consider non-return inferences better than return inferences.

@ahejlsberg ahejlsberg merged commit 94d4023 into master Nov 21, 2019
@ahejlsberg ahejlsberg deleted the fix33568 branch December 25, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inferred type of generic parameter wrong in complex case involving mapped types
3 participants
@ahejlsberg @typescript-bot @weswigham