CommonJS imports support destructuring+property access

[sandersn]

CommonJS imports now support destructuring a require that is part of a property access expression:

const { x } = require('m').o

Previously either worked alone but not together:

const o = require('m').o

const { o } = require('m')

Fixes #40578 for prettier; I didn't think anybody did this, so I let the tests fail earlier. Turns out prettier does!

[weswigham]

Shouldn't all this work be under getTargetOfAliasDeclaration (which resolveSymbol eventually calls out to), and not in getExternalModuleMember directly?

[sandersn]

in the test case below, resolveSymbol is called first on the BindingElement a, which goes to getTargetOfImportSpecifier. Do you mean that function? I put the code in getExternalModuleMember because it seemed similar to the export= code above, and because getExternalModuleMember is called several places.

But looking again, it's only two other places, both exports where this wouldn't apply.

[weswigham]

Suggested change

	if(isVariableDeclaration(node) && node.initializer && isPropertyAccessExpression(node.initializer)) {
	if (isVariableDeclaration(node) && node.initializer && isPropertyAccessExpression(node.initializer)) {

[sandersn]

I tried to commit your suggestion directly but github kept claiming the PR was recently updated =(

[ExE-Boss]

Fun fact: This is also what Node recommends for using the *.promises namespaced APIs before Node v15, which added a large number of */promises alias modules.