Skip to content

Pass in information for the module name resolution when resolutions from file are partially used #49738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 7, 2022
Merged

Pass in information for the module name resolution when resolutions from file are partially used #49738

merged 8 commits into from
Nov 7, 2022

Conversation

sheetalkamat
Copy link
Member

Fixes #48229

@sheetalkamat sheetalkamat requested a review from weswigham June 29, 2022 22:00
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 29, 2022
@sheetalkamat sheetalkamat mentioned this pull request Jun 30, 2022
Merged
@sheetalkamat sheetalkamat added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 22, 2022
@sheetalkamat sheetalkamat force-pushed the partialModuleResolutionReuse branch from 2a075d6 to 5e8682a Compare September 23, 2022 17:28
@sheetalkamat
Copy link
Member Author

Ping for review.. This is marked as 4.9 issue. Note that this tries to fix the issue without breaking API users.

weswigham
weswigham approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make a note to deprecate this signature and replace it with a cleaner one at some point... It's had to change in a backwards-compatible way a lot recently.

@sheetalkamat sheetalkamat merged commit 7b0df1f into main Nov 7, 2022
@sheetalkamat sheetalkamat deleted the partialModuleResolutionReuse branch November 7, 2022 19:51
@weswigham weswigham mentioned this pull request Feb 13, 2023
Closed
@AndrewJakubowicz AndrewJakubowicz mentioned this pull request May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@amcasey amcasey Awaiting requested review from amcasey

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees

@sheetalkamat sheetalkamat

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Referencing module name using index when resolving module name can be incorrect
3 participants
@sheetalkamat @weswigham @typescript-bot