Fix auto import path mapping when first pattern fails #54868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -775,7 +775,9 @@ | |||
| validateEnding({ ending, value }) | |||
| ) { | |||
| const matchedStar = value.substring(prefix.length, value.length - suffix.length); | |||
| return pathIsRelative(matchedStar) ? undefined : key.replace("*", matchedStar); | |||
| if (!pathIsRelative(matchedStar)) { | |||
| return key.replace("*", matchedStar); | |||
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
There was a problem hiding this comment.
=(
Edit: Is there an unambiguous way to replace only once so codeql won't complain? Probably not, that would be too easy.
There was a problem hiding this comment.
Yeah, you can use a global regex, but I don’t want to allocate an object when a string literal will do.
sandersn
approved these changes
Jul 3, 2023
| @@ -775,7 +775,9 @@ | |||
| validateEnding({ ending, value }) | |||
| ) { | |||
| const matchedStar = value.substring(prefix.length, value.length - suffix.length); | |||
| return pathIsRelative(matchedStar) ? undefined : key.replace("*", matchedStar); | |||
| if (!pathIsRelative(matchedStar)) { | |||
| return key.replace("*", matchedStar); | |||
There was a problem hiding this comment.
=(
Edit: Is there an unambiguous way to replace only once so codeql won't complain? Probably not, that would be too easy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54324