support quick info and go to definition on mapped keys #61061

Zzzen · 2025-01-28T09:50:38Z

Fixes #50715, Fixes #56019, Fixes #61094

As mentioned in this comment on GitHub (#50715 (comment)), the @inheritDoc tag is necessary to enable features like quick info and go to definition.

typescript-bot · 2025-01-28T09:50:55Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

jakebailey · 2025-02-22T00:52:50Z

Honestly this feels right to me?

@typescript-bot test it

typescript-bot · 2025-02-22T00:52:54Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-02-22T01:37:11Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,697k (± 1.01%)}	_{194,113k (± 0.95%)}	_~	_192,907k	_196,503k	_{p=0.936 n=6}
_{Parse Time}	_{1.31s (± 0.96%)}	_{1.31s (± 0.75%)}	_~	_1.30s	_1.32s	_{p=0.931 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.73s (± 0.31%)}	_{9.74s (± 0.53%)}	_~	_9.68s	_9.82s	_{p=0.936 n=6}
_{Emit Time}	_{2.73s (± 0.57%)}	_{2.73s (± 0.64%)}	_~	_2.71s	_2.76s	_{p=0.869 n=6}
_{Total Time}	_{14.50s (± 0.19%)}	_{14.51s (± 0.29%)}	_~	_14.44s	_14.55s	_{p=0.871 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,488	_948,488	_~	_~	_~	_{p=1.000 n=6}
_Types	_411,006	_411,006	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,307k (± 0.00%)}	_{1,224,348k (± 0.01%)}	_~	_1,224,283k	_1,224,482k	_{p=0.689 n=6}
_{Parse Time}	_{8.03s (± 1.07%)}	_{7.98s (± 0.89%)}	_~	_7.90s	_8.08s	_{p=0.258 n=6}
_{Bind Time}	_{2.28s (± 0.48%)}	_{2.29s (± 0.39%)}	_~	_2.28s	_2.30s	_{p=0.111 n=6}
_{Check Time}	_{37.98s (± 0.40%)}	_{37.99s (± 0.27%)}	_~	_37.90s	_38.15s	_{p=1.000 n=6}
_{Emit Time}	_{18.39s (± 0.55%)}	_{18.41s (± 0.57%)}	_~	_18.29s	_18.54s	_{p=0.748 n=6}
_{Total Time}	_{66.67s (± 0.29%)}	_{66.67s (± 0.17%)}	_~	_66.52s	_66.85s	_{p=0.873 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,347,440	_2,347,440	_~	_~	_~	_{p=1.000 n=6}
_Types	_845,526	_845,526	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,120,436k (± 0.00%)}	_{2,120,390k (± 0.00%)}	_~	_2,120,347k	_2,120,443k	_{p=0.230 n=6}
_{Parse Time}	_{7.26s (± 0.16%)}	_{7.26s (± 0.14%)}	_~	_7.25s	_7.28s	_{p=0.801 n=6}
_{Bind Time}	_{2.47s (± 1.14%)}	_{2.45s (± 0.26%)}	_~	_2.44s	_2.46s	_{p=0.180 n=6}
_{Check Time}	_{72.48s (± 1.10%)}	_{72.67s (± 0.50%)}	_~	_72.24s	_73.11s	_{p=1.000 n=6}
_{Emit Time}	_{0.15s (± 2.75%)}	_{0.14s (± 3.60%)}	_~	_0.14s	_0.15s	_{p=0.112 n=6}
_{Total Time}	_{82.36s (± 0.92%)}	_{82.53s (± 0.43%)}	_~	_82.10s	_82.97s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,588	_1,226,606	_{+18 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,986	_266,996	_{+10 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,723,670k (±14.66%)}	_{3,088,615k (± 0.03%)}	_~	_3,087,232k	_3,089,492k	_{p=0.093 n=6}
_{Parse Time}	_{6.61s (± 1.48%)}	_{6.72s (± 0.35%)}	_{+0.11s (+ 1.64%)}	_6.69s	_6.75s	_{p=0.030 n=6}
_{Bind Time}	_{2.16s (± 1.64%)}	_{2.16s (± 1.36%)}	_~	_2.12s	_2.20s	_{p=0.688 n=6}
_{Check Time}	_{42.83s (± 0.17%)}	_{42.78s (± 0.22%)}	_~	_42.69s	_42.95s	_{p=0.336 n=6}
_{Emit Time}	_{3.56s (± 2.15%)}	_{3.42s (± 2.87%)}	_{🟩-0.14s (- 3.93%)}	_3.24s	_3.50s	_{p=0.013 n=6}
_{Total Time}	_{55.17s (± 0.18%)}	_{55.07s (± 0.23%)}	_~	_54.92s	_55.29s	_{p=0.173 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,588	_1,226,606	_{+18 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,986	_266,996	_{+10 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,153,474k (± 0.05%)}	_{3,032,491k (± 9.76%)}	_~	_2,427,482k	_3,154,109k	_{p=1.000 n=6}
_{Parse Time}	_{7.00s (± 0.53%)}	_{6.97s (± 0.52%)}	_~	_6.91s	_7.00s	_{p=0.260 n=6}
_{Bind Time}	_{2.14s (± 1.40%)}	_{2.14s (± 1.45%)}	_~	_2.09s	_2.17s	_{p=0.747 n=6}
_{Check Time}	_{42.86s (± 0.21%)}	_{42.85s (± 0.56%)}	_~	_42.44s	_43.10s	_{p=0.873 n=6}
_{Emit Time}	_{3.53s (± 2.19%)}	_{3.54s (± 2.01%)}	_~	_3.43s	_3.62s	_{p=0.748 n=6}
_{Total Time}	_{55.52s (± 0.25%)}	_{55.49s (± 0.44%)}	_~	_55.07s	_55.79s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,667	_262,676	_{+9 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,849	_106,854	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{440,455k (± 0.01%)}	_{440,425k (± 0.02%)}	_~	_440,289k	_440,493k	_{p=0.422 n=6}
_{Parse Time}	_{3.54s (± 0.66%)}	_{3.56s (± 0.92%)}	_~	_3.50s	_3.59s	_{p=0.167 n=6}
_{Bind Time}	_{1.32s (± 1.17%)}	_{1.32s (± 0.62%)}	_~	_1.31s	_1.33s	_{p=0.315 n=6}
_{Check Time}	_{18.97s (± 0.37%)}	_{18.95s (± 0.27%)}	_~	_18.87s	_19.00s	_{p=0.296 n=6}
_{Emit Time}	_{1.52s (± 1.38%)}	_{1.52s (± 1.13%)}	_~	_1.49s	_1.54s	_{p=0.807 n=6}
_{Total Time}	_{25.35s (± 0.32%)}	_{25.35s (± 0.30%)}	_~	_25.22s	_25.42s	_{p=0.872 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,400k (± 0.05%)}	_{371,346k (± 0.01%)}	_~	_371,309k	_371,432k	_{p=0.873 n=6}
_{Parse Time}	_{2.89s (± 1.29%)}	_{2.90s (± 1.08%)}	_~	_2.86s	_2.94s	_{p=0.748 n=6}
_{Bind Time}	_{1.60s (± 1.31%)}	_{1.59s (± 1.47%)}	_~	_1.55s	_1.61s	_{p=0.567 n=6}
_{Check Time}	_{16.47s (± 0.54%)}	_{16.46s (± 0.60%)}	_~	_16.35s	_16.64s	_{p=0.296 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.96s (± 0.47%)}	_{20.94s (± 0.62%)}	_~	_20.78s	_21.16s	_{p=0.521 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,230,018	_3,230,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,095,648	_1,095,648	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,306,590k (± 0.00%)}	_{3,306,652k (± 0.00%)}	_~	_3,306,510k	_3,306,785k	_{p=0.378 n=6}
_{Parse Time}	_{11.71s (± 0.15%)}	_{11.74s (± 0.27%)}	_~	_11.70s	_11.79s	_{p=0.124 n=6}
_{Bind Time}	_{3.82s (± 0.51%)}	_{3.80s (± 0.45%)}	_~	_3.78s	_3.82s	_{p=0.102 n=6}
_{Check Time}	_{74.91s (± 0.40%)}	_{74.94s (± 0.44%)}	_~	_74.51s	_75.37s	_{p=0.936 n=6}
_{Emit Time}	_{23.23s (± 0.28%)}	_{23.20s (± 0.48%)}	_~	_22.98s	_23.26s	_{p=0.870 n=6}
_{Total Time}	_{113.67s (± 0.27%)}	_{113.67s (± 0.36%)}	_~	_113.02s	_114.17s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_293,866	_293,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_119,628	_119,628	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{446,935k (± 0.01%)}	_{446,999k (± 0.02%)}	_~	_446,939k	_447,132k	_{p=0.066 n=6}
_{Parse Time}	_{3.31s (± 0.37%)}	_{3.29s (± 0.17%)}	_~	_3.29s	_3.30s	_{p=0.090 n=6}
_{Bind Time}	_{1.48s (± 0.70%)}	_{1.46s (± 0.57%)}	_{-0.02s (- 1.24%)}	_1.45s	_1.47s	_{p=0.010 n=6}
_{Check Time}	_{15.62s (± 0.24%)}	_{15.65s (± 0.31%)}	_~	_15.57s	_15.70s	_{p=0.224 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.41s (± 0.15%)}	_{20.42s (± 0.22%)}	_~	_20.34s	_20.46s	_{p=0.572 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_559,094	_559,094	_~	_~	_~	_{p=1.000 n=6}
_Types	_187,011	_187,011	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{496,166k (± 0.03%)}	_{496,152k (± 0.03%)}	_~	_495,878k	_496,285k	_{p=0.873 n=6}
_{Parse Time}	_{3.42s (± 0.75%)}	_{3.43s (± 1.13%)}	_~	_3.40s	_3.48s	_{p=0.806 n=6}
_{Bind Time}	_{1.20s (± 0.86%)}	_{1.19s (± 1.14%)}	_~	_1.17s	_1.21s	_{p=0.241 n=6}
_{Check Time}	_{19.71s (± 1.06%)}	_{19.83s (± 2.07%)}	_~	_19.57s	_20.66s	_{p=0.688 n=6}
_{Emit Time}	_{0.01s (±154.76%)}	_0.00s	_~	_~	_~	_{p=0.174 n=6}
_{Total Time}	_{24.34s (± 0.89%)}	_{24.46s (± 1.80%)}	_~	_24.15s	_25.34s	_{p=0.748 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-02-22T01:50:38Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-02-22T02:13:58Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61061/merge:

Everything looks good!

jakebailey · 2025-02-24T19:57:07Z

src/services/goToDefinition.ts

@@ -595,7 +597,8 @@ function isExpandoDeclaration(node: Declaration): boolean {
 }

 function getDefinitionFromSymbol(typeChecker: TypeChecker, symbol: Symbol, node: Node, failedAliasResolution?: boolean, declarationFilter?: (d: Declaration) => boolean): DefinitionInfo[] | undefined {
-    const filteredDeclarations = declarationFilter !== undefined ? filter(symbol.declarations, declarationFilter) : symbol.declarations;
+    const declarations = isTransientSymbol(symbol) && symbol.links.checkFlags & CheckFlags.Mapped && !symbol.declarations?.length ? symbol.links.syntheticOrigin?.declarations : symbol.declarations;


I find it sort of concerning to reach into the links like this; I can see maybe one or two other cases where we've done symbol.links outside the checker and I can't say I like those either. Is there no other way to do this?

I agree with your concern about reaching into symbol.links. I think there might be a better way to handle this. Maybe we can create a helper function that gets the documentation from the original symbol without directly accessing links. That would make the code more maintainable and less dependent on internal implementation details.

support quick info and go to definition on mapped keys

712ee1b

format and add tests

a2bcfaa

jakebailey reviewed Feb 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support quick info and go to definition on mapped keys #61061

support quick info and go to definition on mapped keys #61061

Zzzen commented Jan 28, 2025 •

edited

Loading

typescript-bot commented Jan 28, 2025

jakebailey commented Feb 22, 2025

typescript-bot commented Feb 22, 2025 •

edited

Loading

typescript-bot commented Feb 22, 2025

tsc

typescript-bot commented Feb 22, 2025

typescript-bot commented Feb 22, 2025

jakebailey Feb 24, 2025

Zzzen Mar 12, 2025

support quick info and go to definition on mapped keys #61061

Are you sure you want to change the base?

support quick info and go to definition on mapped keys #61061

Conversation

Zzzen commented Jan 28, 2025 • edited Loading

typescript-bot commented Jan 28, 2025

jakebailey commented Feb 22, 2025

typescript-bot commented Feb 22, 2025 • edited Loading

typescript-bot commented Feb 22, 2025

tsc

typescript-bot commented Feb 22, 2025

typescript-bot commented Feb 22, 2025

jakebailey Feb 24, 2025

Choose a reason for hiding this comment

Zzzen Mar 12, 2025

Choose a reason for hiding this comment

Zzzen commented Jan 28, 2025 •

edited

Loading

typescript-bot commented Feb 22, 2025 •

edited

Loading