Revert "Proposed expandable hover API" #61132

gabritto · 2025-02-06T19:10:47Z

Reverts #59940.

We merged it just to enable internal testing of the prototype implementation, so I'm reverting this for 5.8 RC, and a polished version should go in for 5.9.

This reverts commit 80eeb4e.

typescript-bot · 2025-02-06T19:11:07Z

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, @zkat, and @joj for you. Feel free to loop in other consumers/maintainers if necessary.

typescript-bot · 2025-02-06T19:11:08Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

gabritto · 2025-02-07T00:55:40Z

@typescript-bot test it

typescript-bot · 2025-02-07T00:55:45Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-02-07T01:17:33Z

@gabritto Here are the results of running the user tests with tsc comparing main and refs/pull/61132/merge:

Everything looks good!

typescript-bot · 2025-02-07T01:19:37Z

Hey @gabritto, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-02-07T01:41:09Z

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,950k (± 1.02%)}	_{193,762k (± 0.81%)}	_~	_193,107k	_196,959k	_{p=0.297 n=6}
_{Parse Time}	_{1.32s (± 1.03%)}	_{1.31s (± 0.84%)}	_~	_1.30s	_1.32s	_{p=0.090 n=6}
_{Bind Time}	_0.73s	_{0.73s (± 0.70%)}	_~	_0.73s	_0.74s	_{p=0.174 n=6}
_{Check Time}	_{9.78s (± 0.14%)}	_{9.81s (± 0.29%)}	_~	_9.77s	_9.84s	_{p=0.187 n=6}
_{Emit Time}	_{2.75s (± 0.65%)}	_{2.76s (± 0.85%)}	_~	_2.73s	_2.80s	_{p=0.623 n=6}
_{Total Time}	_{14.59s (± 0.20%)}	_{14.61s (± 0.31%)}	_~	_14.53s	_14.65s	_{p=0.335 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,488	_948,488	_~	_~	_~	_{p=1.000 n=6}
_Types	_411,006	_411,006	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,422k (± 0.00%)}	_{1,225,425k (± 0.00%)}	_~	_1,225,366k	_1,225,523k	_{p=0.810 n=6}
_{Parse Time}	_{6.69s (± 0.93%)}	_{6.73s (± 0.55%)}	_~	_6.65s	_6.75s	_{p=0.183 n=6}
_{Bind Time}	_{1.93s (± 0.71%)}	_{1.93s (± 0.53%)}	_~	_1.92s	_1.95s	_{p=0.557 n=6}
_{Check Time}	_{32.16s (± 0.22%)}	_{32.12s (± 0.46%)}	_~	_31.98s	_32.38s	_{p=0.294 n=6}
_{Emit Time}	_{15.32s (± 0.85%)}	_{15.40s (± 0.36%)}	_~	_15.35s	_15.49s	_{p=0.148 n=6}
_{Total Time}	_{56.09s (± 0.34%)}	_{56.17s (± 0.29%)}	_~	_55.93s	_56.41s	_{p=0.336 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,371,940	_2,371,940	_~	_~	_~	_{p=1.000 n=6}
_Types	_846,141	_846,141	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,138,901k (± 0.00%)}	_{2,138,924k (± 0.00%)}	_~	_2,138,841k	_2,139,057k	_{p=0.810 n=6}
_{Parse Time}	_{7.31s (± 0.17%)}	_{7.31s (± 0.16%)}	_~	_7.29s	_7.32s	_{p=0.504 n=6}
_{Bind Time}	_{2.49s (± 0.39%)}	_{2.49s (± 0.57%)}	_~	_2.47s	_2.51s	_{p=0.869 n=6}
_{Check Time}	_{73.10s (± 0.46%)}	_{72.93s (± 1.17%)}	_~	_71.29s	_73.77s	_{p=1.000 n=6}
_{Emit Time}	_{0.14s (± 3.60%)}	_{0.15s (± 2.75%)}	_~	_0.14s	_0.15s	_{p=0.112 n=6}
_{Total Time}	_{83.05s (± 0.40%)}	_{82.88s (± 1.02%)}	_~	_81.26s	_83.71s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,228,747	_{-650 (- 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,085	_267,002	_{-83 (- 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,362,138k (± 0.01%)}	_{2,361,149k (± 0.02%)}	_{-990k (- 0.04%)}	_2,360,332k	_2,361,938k	_{p=0.013 n=6}
_{Parse Time}	_{5.24s (± 0.57%)}	_{5.23s (± 0.61%)}	_~	_5.18s	_5.26s	_{p=0.748 n=6}
_{Bind Time}	_{1.81s (± 0.75%)}	_{1.82s (± 0.85%)}	_~	_1.79s	_1.83s	_{p=0.193 n=6}
_{Check Time}	_{35.46s (± 0.24%)}	_{35.48s (± 0.42%)}	_~	_35.31s	_35.64s	_{p=0.810 n=6}
_{Emit Time}	_{3.04s (± 1.11%)}	_{3.01s (± 1.06%)}	_~	_2.95s	_3.04s	_{p=0.223 n=6}
_{Total Time}	_{45.57s (± 0.20%)}	_{45.55s (± 0.32%)}	_~	_45.40s	_45.74s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,228,747	_{-650 (- 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,085	_267,002	_{-83 (- 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,917,309k (±12.89%)}	_{3,158,807k (± 0.02%)}	_~	_3,158,248k	_3,159,697k	_{p=0.471 n=6}
_{Parse Time}	_{6.91s (± 2.15%)}	_{7.02s (± 0.75%)}	_~	_6.98s	_7.12s	_{p=0.199 n=6}
_{Bind Time}	_{2.14s (± 1.24%)}	_{2.13s (± 0.97%)}	_~	_2.10s	_2.15s	_{p=0.257 n=6}
_{Check Time}	_{42.88s (± 0.40%)}	_{42.93s (± 0.19%)}	_~	_42.78s	_43.00s	_{p=0.575 n=6}
_{Emit Time}	_{3.56s (± 2.45%)}	_{3.44s (± 2.66%)}	_~	_3.33s	_3.54s	_{p=0.054 n=6}
_{Total Time}	_{55.50s (± 0.47%)}	_{55.52s (± 0.32%)}	_~	_55.23s	_55.78s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,074	_263,031	_{-43 (- 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,881	_106,875	_{-6 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{441,319k (± 0.02%)}	_{441,252k (± 0.03%)}	_~	_441,129k	_441,440k	_{p=0.128 n=6}
_{Parse Time}	_{3.56s (± 0.95%)}	_{3.55s (± 1.25%)}	_~	_3.49s	_3.61s	_{p=0.936 n=6}
_{Bind Time}	_{1.32s (± 0.75%)}	_{1.32s (± 0.89%)}	_~	_1.30s	_1.33s	_{p=1.000 n=6}
_{Check Time}	_{19.04s (± 0.38%)}	_{18.98s (± 0.40%)}	_~	_18.90s	_19.11s	_{p=0.199 n=6}
_{Emit Time}	_{1.53s (± 0.92%)}	_{1.52s (± 0.87%)}	_~	_1.50s	_1.53s	_{p=0.392 n=6}
_{Total Time}	_{25.45s (± 0.30%)}	_{25.37s (± 0.46%)}	_~	_25.24s	_25.55s	_{p=0.229 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,860k (± 0.05%)}	_{371,780k (± 0.04%)}	_~	_371,669k	_372,058k	_{p=0.689 n=6}
_{Parse Time}	_{2.89s (± 0.89%)}	_{2.87s (± 0.60%)}	_~	_2.85s	_2.89s	_{p=0.373 n=6}
_{Bind Time}	_{1.58s (± 0.53%)}	_{1.59s (± 1.10%)}	_~	_1.56s	_1.61s	_{p=0.933 n=6}
_{Check Time}	_{16.38s (± 0.23%)}	_{16.42s (± 0.33%)}	_~	_16.37s	_16.51s	_{p=0.147 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{20.85s (± 0.30%)}	_{20.88s (± 0.33%)}	_~	_20.81s	_20.99s	_{p=0.572 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,280,686	_3,280,686	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,128,284	_1,128,284	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,354,740k (± 0.01%)}	_{3,354,738k (± 0.01%)}	_~	_3,354,302k	_3,355,057k	_{p=0.936 n=6}
_{Parse Time}	_{14.60s (± 0.47%)}	_{14.63s (± 0.56%)}	_~	_14.51s	_14.71s	_{p=0.470 n=6}
_{Bind Time}	_{4.64s (± 0.60%)}	_{4.62s (± 0.42%)}	_~	_4.60s	_4.65s	_{p=0.332 n=6}
_{Check Time}	_{91.52s (± 3.18%)}	_{89.42s (± 1.84%)}	_~	_88.51s	_92.76s	_{p=0.066 n=6}
_{Emit Time}	_{27.52s (± 8.52%)}	_{28.02s (± 2.00%)}	_~	_27.65s	_29.11s	_{p=0.936 n=6}
_{Total Time}	_{138.28s (± 1.79%)}	_{136.69s (± 1.25%)}	_~	_135.36s	_139.84s	_{p=0.199 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_293,378	_293,378	_~	_~	_~	_{p=1.000 n=6}
_Types	_119,581	_119,581	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{447,128k (± 0.02%)}	_{447,142k (± 0.02%)}	_~	_447,022k	_447,323k	_{p=0.810 n=6}
_{Parse Time}	_{4.11s (± 0.41%)}	_{4.10s (± 0.73%)}	_~	_4.06s	_4.14s	_{p=0.744 n=6}
_{Bind Time}	_{1.78s (± 1.61%)}	_{1.76s (± 0.85%)}	_~	_1.75s	_1.79s	_{p=0.510 n=6}
_{Check Time}	_{18.76s (± 0.56%)}	_{18.82s (± 0.61%)}	_~	_18.67s	_18.95s	_{p=0.628 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.65s (± 0.40%)}	_{24.68s (± 0.41%)}	_~	_24.55s	_24.82s	_{p=0.629 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,375	_555,375	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,146	_186,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{494,532k (± 0.01%)}	_{494,507k (± 0.03%)}	_~	_494,225k	_494,712k	_{p=1.000 n=6}
_{Parse Time}	_{3.40s (± 0.58%)}	_{3.39s (± 0.87%)}	_~	_3.37s	_3.45s	_{p=0.277 n=6}
_{Bind Time}	_{1.18s (± 1.12%)}	_{1.19s (± 1.56%)}	_~	_1.18s	_1.23s	_{p=0.241 n=6}
_{Check Time}	_{19.57s (± 0.18%)}	_{19.63s (± 1.11%)}	_~	_19.45s	_20.04s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.16s (± 0.22%)}	_{24.22s (± 0.87%)}	_~	_24.04s	_24.61s	_{p=0.872 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-02-07T02:40:41Z

@gabritto Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61132/merge:

Everything looks good!

jakebailey

Does VS Code need to know to not send this request anymore, or will it "just work" because the extra data will be ignored?

gabritto · 2025-02-07T18:55:02Z

Does VS Code need to know to not send this request anymore, or will it "just work" because the extra data will be ignored?

Good question, I'll double check.

mjbvz · 2025-02-07T20:12:50Z

@gabritto On the VS Code side we gate our check to TS 5.7 , not specific pre-release version (plus you need the setting enabled). If you're planning to remove this, can you update VS Code to only send this request on TS 5.9+

gabritto · 2025-02-07T20:42:53Z

@gabritto On the VS Code side we gate our check to TS 5.7 , not specific pre-release version (plus you need the setting enabled). If you're planning to remove this, can you update VS Code to only send this request on TS 5.9+

@mjbvz should I temporarily remove the whole feature from the vscode side as well? I could update it to only send the request for TS 5.9+, but in theory, we'll ship TS 5.9 nightly versions starting next week, and I won't bring this back into TSServer time for that. On the same vein, I'd also have to remove the setting.

gabritto · 2025-02-07T20:43:53Z

Does VS Code need to know to not send this request anymore, or will it "just work" because the extra data will be ignored?

Good question, I'll double check.

I checked, and it works.

mylesmmurphy · 2025-02-10T17:25:15Z

Hey @gabritto! Really great work on this, very excited to see this coming. I have some feedback / questions related to this that I mentioned here, and felt it might be relevant to your work and would love your feedback. 😄

Revert "Proposed expandable hover API (#59940)"

0e05281

This reverts commit 80eeb4e.

typescript-bot assigned gabritto Feb 6, 2025

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 6, 2025

jakebailey approved these changes Feb 7, 2025

View reviewed changes

gabritto merged commit 34ea32f into main Feb 7, 2025
32 checks passed

gabritto deleted the revert-59940-gabritto/issue59029 branch February 7, 2025 20:44

gabritto mentioned this pull request Feb 7, 2025

Revert "[typescript-language-features] Expandable hover (#228255)" microsoft/vscode#240011

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Proposed expandable hover API" #61132

Revert "Proposed expandable hover API" #61132

gabritto commented Feb 6, 2025

typescript-bot commented Feb 6, 2025

typescript-bot commented Feb 6, 2025

gabritto commented Feb 7, 2025

typescript-bot commented Feb 7, 2025 •

edited

Loading

typescript-bot commented Feb 7, 2025

typescript-bot commented Feb 7, 2025

typescript-bot commented Feb 7, 2025

tsc

typescript-bot commented Feb 7, 2025

jakebailey left a comment

gabritto commented Feb 7, 2025

mjbvz commented Feb 7, 2025

gabritto commented Feb 7, 2025

gabritto commented Feb 7, 2025

mylesmmurphy commented Feb 10, 2025

Revert "Proposed expandable hover API" #61132

Revert "Proposed expandable hover API" #61132

Conversation

gabritto commented Feb 6, 2025

typescript-bot commented Feb 6, 2025

typescript-bot commented Feb 6, 2025

gabritto commented Feb 7, 2025

typescript-bot commented Feb 7, 2025 • edited Loading

typescript-bot commented Feb 7, 2025

typescript-bot commented Feb 7, 2025

typescript-bot commented Feb 7, 2025

tsc

typescript-bot commented Feb 7, 2025

jakebailey left a comment

Choose a reason for hiding this comment

gabritto commented Feb 7, 2025

mjbvz commented Feb 7, 2025

gabritto commented Feb 7, 2025

gabritto commented Feb 7, 2025

mylesmmurphy commented Feb 10, 2025

typescript-bot commented Feb 7, 2025 •

edited

Loading