Skip to content

Avoid an attempt to contextually type static property declaration using itself to avoid spurious circularity #62554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+144 −1
Open

Avoid an attempt to contextually type static property declaration using itself to avoid spurious circularity #62554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31886,7 +31886,8 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {

function getContextualTypeForStaticPropertyDeclaration(declaration: PropertyDeclaration, contextFlags: ContextFlags | undefined): Type | undefined {
const parentType = isExpression(declaration.parent) && getContextualType(declaration.parent, contextFlags);
if (!parentType) return undefined;
// Avoid spurious circularities caused by trying to contextually type a static property with an in-progress type using its own (still potentially unresolved) type
if (!parentType || parentType.symbol?.valueDeclaration === declaration.parent) return undefined;
return getTypeOfPropertyOfContextualType(parentType, getSymbolOfDeclaration(declaration).escapedName);
}

Expand Down
46 changes: 46 additions & 0 deletions tests/baselines/reference/classStaticPropertyNoSpuriousCircularityError1.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
//// [tests/cases/compiler/classStaticPropertyNoSpuriousCircularityError1.ts] ////

=== classStaticPropertyNoSpuriousCircularityError1.ts ===
// https://github.com/microsoft/TypeScript/issues/62552

function id<T>(x: T): T {
>id : Symbol(id, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 0, 0))
>T : Symbol(T, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 2, 12))
>x : Symbol(x, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 2, 15))
>T : Symbol(T, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 2, 12))
>T : Symbol(T, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 2, 12))

return x
>x : Symbol(x, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 2, 15))
}

const Foo = id(class {
>Foo : Symbol(Foo, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 6, 5))
>id : Symbol(id, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 0, 0))

static readonly foo = id(42) // ok
>foo : Symbol((Anonymous class).foo, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 6, 22))
>id : Symbol(id, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 0, 0))

})

Foo.foo // 42
>Foo.foo : Symbol((Anonymous class).foo, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 6, 22))
>Foo : Symbol(Foo, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 6, 5))
>foo : Symbol((Anonymous class).foo, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 6, 22))

const Foo2 = id(class {
>Foo2 : Symbol(Foo2, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 12, 5))
>id : Symbol(id, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 0, 0))

static foo = id(42) // ok
>foo : Symbol((Anonymous class).foo, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 12, 23))
>id : Symbol(id, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 0, 0))

})

Foo2.foo // number
>Foo2.foo : Symbol((Anonymous class).foo, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 12, 23))
>Foo2 : Symbol(Foo2, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 12, 5))
>foo : Symbol((Anonymous class).foo, Decl(classStaticPropertyNoSpuriousCircularityError1.ts, 12, 23))

76 changes: 76 additions & 0 deletions tests/baselines/reference/classStaticPropertyNoSpuriousCircularityError1.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
//// [tests/cases/compiler/classStaticPropertyNoSpuriousCircularityError1.ts] ////

=== classStaticPropertyNoSpuriousCircularityError1.ts ===
// https://github.com/microsoft/TypeScript/issues/62552

function id<T>(x: T): T {
>id : <T>(x: T) => T
> : ^ ^^ ^^ ^^^^^
>x : T
> : ^

return x
>x : T
> : ^
}

const Foo = id(class {
>Foo : typeof (Anonymous class)
> : ^^^^^^^^^^^^^^^^^^^^^^^^
>id(class { static readonly foo = id(42) // ok}) : typeof (Anonymous class)
> : ^^^^^^^^^^^^^^^^^^^^^^^^
>id : <T>(x: T) => T
> : ^ ^^ ^^ ^^^^^
>class { static readonly foo = id(42) // ok} : typeof (Anonymous class)
> : ^^^^^^^^^^^^^^^^^^^^^^^^

static readonly foo = id(42) // ok
>foo : 42
> : ^^
>id(42) : 42
> : ^^
>id : <T>(x: T) => T
> : ^ ^^ ^^ ^^^^^
>42 : 42
> : ^^

})

Foo.foo // 42
>Foo.foo : 42
> : ^^
>Foo : typeof (Anonymous class)
> : ^^^^^^^^^^^^^^^^^^^^^^^^
>foo : 42
> : ^^

const Foo2 = id(class {
>Foo2 : typeof (Anonymous class)
> : ^^^^^^^^^^^^^^^^^^^^^^^^
>id(class { static foo = id(42) // ok}) : typeof (Anonymous class)
> : ^^^^^^^^^^^^^^^^^^^^^^^^
>id : <T>(x: T) => T
> : ^ ^^ ^^ ^^^^^
>class { static foo = id(42) // ok} : typeof (Anonymous class)
> : ^^^^^^^^^^^^^^^^^^^^^^^^

static foo = id(42) // ok
>foo : number
> : ^^^^^^
>id(42) : 42
> : ^^
>id : <T>(x: T) => T
> : ^ ^^ ^^ ^^^^^
>42 : 42
> : ^^

})

Foo2.foo // number
>Foo2.foo : number
> : ^^^^^^
>Foo2 : typeof (Anonymous class)
> : ^^^^^^^^^^^^^^^^^^^^^^^^
>foo : number
> : ^^^^^^

20 changes: 20 additions & 0 deletions tests/cases/compiler/classStaticPropertyNoSpuriousCircularityError1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// @strict: true
// @noEmit: true

// https://github.com/microsoft/TypeScript/issues/62552

function id<T>(x: T): T {
return x
}

const Foo = id(class {
static readonly foo = id(42) // ok
})

Foo.foo // 42

const Foo2 = id(class {
static foo = id(42) // ok
})

Foo2.foo // number