Update error for allowImportingTsExtensions to mention rewriteRelativeImportExtensions #62557
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eImportExtensions
There was a problem hiding this comment.
Pull Request Overview
This PR updates the error message for the allowImportingTsExtensions compiler option to accurately reflect all valid configurations. The error now mentions that rewriteRelativeImportExtensions is also a valid option alongside noEmit and emitDeclarationOnly.
- Updates the diagnostic message text to include
rewriteRelativeImportExtensionsas a third valid option - Updates the corresponding diagnostic key in the messages file
- Updates test baselines to reflect the new error message
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/compiler/program.ts | Updated diagnostic key reference to use the new message |
| src/compiler/diagnosticMessages.json | Updated error message text to include rewriteRelativeImportExtensions |
| tests/baselines/reference/bundlerImportTsExtensions(allowimportingtsextensions=true,noemit=false).errors.txt | Updated test baseline to reflect new error message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60397.
error TS5096 currently says
But in fact
rewriteRelativeImportExtensionsalso works (as you can see from the line above the change insrc/compiler/program.tsin this PR), and is often what I at least am reaching for. This PR updates it to read