-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Library modularization #6990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library modularization #6990
Conversation
Break ES6 library Remove unused ES6
Break ES7 library Remove unused es7
]; | ||
|
||
var es6LibrarySourceMap = es6LibrarySources.map(function(source) { | ||
return { target: "lib." + source, sources: ["header.d.ts", source ] }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4-space tabs
|
|
||
interface Array<T> { | ||
/** Iterator */ | ||
[Symbol.iterator](): IterableIterator<T>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider moving these to es6.iterbales.d.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍵 same go to well-known symbol
so are we adding lib.node.d.ts and lib.browser.d.ts in a different change? |
@yuit I think it's OK, if We could easily combine two library. Thank you. |
{ target: "lib.full.es6.d.ts", sources: ["header.d.ts", "es5.d.ts"].concat(es6LibrarySources, hostsLibrarySources), }, | ||
|
||
// Preset JavaScript & host library | ||
{ target: "lib.dom.es5.d.ts", sources:["header.d.ts", "importes5.d.ts", "intl.d.ts", "dom.generated.d.ts"], }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i do not think we need these two
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would merge intel with es5 for now.
you need to make the change to program.ts |
nice, great for quickstarts! 😎 |
closing in favor of #7715 |
This is part of the larger work item #6974.