Skip to content

Library modularization #6990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 46 commits into from
Closed

Library modularization #6990

wants to merge 46 commits into from

Conversation

yuit
Copy link
Contributor

@yuit yuit commented Feb 9, 2016

This is part of the larger work item #6974.

  • Breaking up the library
  • Adding compiler options (this may cause some re-thinking about library breaking)
  • Language Service support in VS
  • Add node.d.ts and browser.d.ts

@yuit yuit mentioned this pull request Feb 9, 2016
4 tasks
@DanielRosenwasser DanielRosenwasser changed the title Breaking library Library modularization Feb 10, 2016
];

var es6LibrarySourceMap = es6LibrarySources.map(function(source) {
return { target: "lib." + source, sources: ["header.d.ts", source ] };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4-space tabs

@mhegazy
Copy link
Contributor

mhegazy commented Feb 10, 2016

es7.array-include.d.ts => es7.array.include.d.ts or justees7.array.d.ts


interface Array<T> {
/** Iterator */
[Symbol.iterator](): IterableIterator<T>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider moving these to es6.iterbales.d.ts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍵 same go to well-known symbol

@mhegazy
Copy link
Contributor

mhegazy commented Feb 10, 2016

so are we adding lib.node.d.ts and lib.browser.d.ts in a different change?

@YuichiNukiyama
Copy link
Contributor

@yuit I think it's OK, if We could easily combine two library. Thank you.

{ target: "lib.full.es6.d.ts", sources: ["header.d.ts", "es5.d.ts"].concat(es6LibrarySources, hostsLibrarySources), },

// Preset JavaScript & host library
{ target: "lib.dom.es5.d.ts", sources:["header.d.ts", "importes5.d.ts", "intl.d.ts", "dom.generated.d.ts"], },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do not think we need these two

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would merge intel with es5 for now.

@mhegazy
Copy link
Contributor

mhegazy commented Feb 26, 2016

you need to make the change to program.ts

@basarat
Copy link
Contributor

basarat commented Feb 26, 2016

lib.node.d.ts

nice, great for quickstarts! 😎

@mhegazy
Copy link
Contributor

mhegazy commented Mar 29, 2016

closing in favor of #7715

@mhegazy mhegazy closed this Mar 29, 2016
@mhegazy mhegazy deleted the breakinglibrary branch April 4, 2016 20:48
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants