Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agentic memory #5227

Open
wants to merge 98 commits into
base: main
Choose a base branch
from
Open

Agentic memory #5227

wants to merge 98 commits into from

Conversation

rickyloynd-microsoft
Copy link
Contributor

@rickyloynd-microsoft rickyloynd-microsoft commented Jan 28, 2025

Adds a baseline implementation of agentic memory to the autogen-ext package.

For technical details, see the Agentic Memory README.

To see it in action, view the page logs generated while running the code samples.

In-progress:

  • Unit tests
  • Potential usage of autogen-core/memory

Make memory optional.
Filter out insights with negative scores.
Refactor memory paths.
Enrich page logging.
Seed messages with random int for variability.
Save sessions as yaml for readability.
Eval simplifications.
@ekzhu
Copy link
Collaborator

ekzhu commented Jan 29, 2025

I haven't gone deep into the implementation logics, but I believe from just API level, we need to work on it to make sure it aligns with the rest of the framework. E.g., serializable configuration is already supported, and we should be using that. TaskRunner protocol is already there, and we should be using that. BaseChatAgent already provides an agent abstraction, and we should be using that as well.

Copy link
Member

@jackgerrits jackgerrits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is simply too large. Please propose your changes progressively and iteratively using a separate sequence of PRs. We cannot effectively review these changes as is.

@ekzhu
Copy link
Collaborator

ekzhu commented Jan 30, 2025

@jackgerrits we will be refactoring this in the current branch first

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 925 lines in your changes missing coverage. Please review.

Project coverage is 70.97%. Comparing base (5c969d3) to head (6a04851).

Files with missing lines Patch % Lines
...-ext/src/autogen_ext/agentic_memory/page_logger.py 0.00% 250 Missing ⚠️
...en_ext/agentic_memory/agentic_memory_controller.py 0.00% 194 Missing ⚠️
...en-ext/src/autogen_ext/agentic_memory/_prompter.py 0.00% 116 Missing ⚠️
...n-ext/src/autogen_ext/agentic_memory/apprentice.py 0.00% 95 Missing ⚠️
...autogen_ext/agentic_memory/_agentic_memory_bank.py 0.00% 83 Missing ⚠️
...togen-ext/src/autogen_ext/agentic_memory/grader.py 0.00% 74 Missing ⚠️
...togen_ext/agentic_memory/_string_similarity_map.py 0.00% 64 Missing ⚠️
...togen-ext/src/autogen_ext/agentic_memory/_utils.py 0.00% 44 Missing ⚠️
...gen-ext/src/autogen_ext/agentic_memory/__init__.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5227      +/-   ##
==========================================
- Coverage   77.85%   70.97%   -6.89%     
==========================================
  Files         158      167       +9     
  Lines        9520    10445     +925     
==========================================
+ Hits         7412     7413       +1     
- Misses       2108     3032     +924     
Flag Coverage Δ
unittests 70.97% <0.00%> (-6.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants