Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception Handling Policy #5268

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

BenConstable9
Copy link

Why are these changes needed?

This adds an exception handling policy that allows the group chat to raise the underlying exception if needed. Default behaviour is not changed.

Related issue number

Closes #4904

Checks

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackgerrits @BenConstable9 for AgentChat layer, I think we should first expose the runtime as a separate parameter in the group chats' constructors, then setting the exception handling policy through the runtime's constructor.

Let's focus on the Core API layer for now?

For the AgentChat layer, if you want to set the policy, do it for now by setting the exception handling policy of the _runtime attribute directly. I believe we need to first expose runtime as a new constructor argument for the group chat classes. The correct way should be setting the policy on the runtime, and then pass the runtime through the group chats.

@jackgerrits
Copy link
Member

Agreed with @ekzhu, let's not expose directly in agentchat for now and stick to just core. Digging up the _runtime property is a good short term compromise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling policy for unhandled agent exceptions
3 participants