Fix streaming in distributed group chat example #5336
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohMaz
force-pushed
the
fix-streaming-in-distributed-group-chat-example
branch
from
2ee11d9 to
7ea6b02
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5336 +/- ##
=======================================
Coverage 76.02% 76.02%
=======================================
Files 157 157
Lines 9491 9491
=======================================
Hits 7216 7216
Misses 2275 2275
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ekzhu
reviewed
Feb 3, 2025
|
|
||
| await publish_message_to_ui_and_backend( | ||
| stream_output = self._model_client.create_stream( | ||
| messages=[self._system_message] + self._chat_history, max_consecutive_empty_chunk_tolerance=3 |
There was a problem hiding this comment.
The max_consecutive_empty_chunk_tolerance will need to be removed.
There was a problem hiding this comment.
Correct, as we are installing dependencies for the sample from PyPi, we have to options on when to remove it:
- Remove it now, keep this PR open until we release another autogenerated version which contains the new logic
- Merge this PR, be ok with deprecation warning after a new release, and remove it when we will remove other packages.
@ekzhu please advice
MohMaz
force-pushed
the
fix-streaming-in-distributed-group-chat-example
branch
from
7ea6b02 to
ef4129c
Compare
Signed-off-by: Mohammad Mazraeh <[email protected]>
Signed-off-by: Mohammad Mazraeh <[email protected]>
MohMaz
force-pushed
the
fix-streaming-in-distributed-group-chat-example
branch
from
ef4129c to
2cfabaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Recreates #4440 to support actual streaming in core_distributed-group-chat sample
Related issue number
Checks