Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dotnet runtime tests #5342

Merged
merged 7 commits into from
Feb 5, 2025
Merged

Conversation

bassmang
Copy link
Collaborator

@bassmang bassmang commented Feb 3, 2025

No description provided.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.86%. Comparing base (9030f75) to head (bc5fb33).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5342   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files         158      158           
  Lines        9520     9520           
=======================================
  Hits         7413     7413           
  Misses       2107     2107           
Flag Coverage Δ
unittests 77.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jackgerrits jackgerrits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default this behavior should be disabled but it looks to me like this test is showing that it is enabled by default? Looks like a bug

@bassmang
Copy link
Collaborator Author

bassmang commented Feb 3, 2025

By default this behavior should be disabled but it looks to me like this test is showing that it is enabled by default? Looks like a bug

True it is supposed to have the property explicitly set, I'll look into it

@jackgerrits jackgerrits added the dotnet issues related to AutoGen.Net label Feb 4, 2025
@bassmang bassmang merged commit 442df18 into microsoft:main Feb 5, 2025
66 checks passed
@bassmang bassmang deleted the dotnet_unit_rt branch February 5, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet issues related to AutoGen.Net
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants