Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back grpc service #5377

Merged
merged 62 commits into from
Feb 8, 2025
Merged

bring back grpc service #5377

merged 62 commits into from
Feb 8, 2025

Conversation

rysweet
Copy link
Collaborator

@rysweet rysweet commented Feb 5, 2025

Restoring the grpc + Orleans server into the project

Why are these changes needed?

This is the distributed agent runtime for .NET that can manage routing messages amongst a fleet of grpc agent runtimes.

Related issue number

Checks

@rysweet rysweet marked this pull request as draft February 5, 2025 16:58
@rysweet rysweet changed the title Rysweet grpc service bring back grpc service Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.17%. Comparing base (9494ac9) to head (ecb15ae).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ft.AutoGen/Core/TypePrefixSubscriptionAttribute.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5377      +/-   ##
==========================================
- Coverage   78.11%   76.17%   -1.95%     
==========================================
  Files         158      196      +38     
  Lines        9590    10672    +1082     
  Branches        0      139     +139     
==========================================
+ Hits         7491     8129     +638     
- Misses       2099     2448     +349     
- Partials        0       95      +95     
Flag Coverage Δ
unittests 76.17% <75.00%> (-1.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rysweet rysweet requested a review from Copilot February 7, 2025 08:23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 55 out of 70 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • dotnet/AutoGen.sln: Language not supported
  • dotnet/src/Microsoft.AutoGen/AgentHost/Microsoft.AutoGen.AgentHost.csproj: Language not supported
  • dotnet/src/Microsoft.AutoGen/Agents/Microsoft.AutoGen.Agents.csproj: Language not supported
  • dotnet/src/Microsoft.AutoGen/Runtime.Grpc/Services/Grpc/GrpcGatewayService.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Runtime.Grpc/Abstractions/IAgentGrain.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/AgentHost/Program.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Core/AgentRuntimeExtensions.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Core.Grpc/GrpcAgentRuntime.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/AgentHost/Host.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Core/TypePrefixSubscriptionAttribute.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Agents/AIAgent/InferenceAgent.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Agents/protos/agent_events.proto: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/RuntimeGateway.Grpc/Abstractions/AgentsMetadata.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/RuntimeGateway.Grpc/Abstractions/AgentsRegistryState.cs: Evaluated as low risk
  • dotnet/src/Microsoft.AutoGen/Agents/IOAgent/ConsoleAgent/IHandleConsole.cs: Evaluated as low risk
Comments suppressed due to low confidence (3)

dotnet/src/Microsoft.AutoGen/Agents/IOAgent/FileAgent/IHandleFileIO.cs:23

  • [nitpick] Defining constants inside an interface is not a common practice. Consider moving the Route constant to a class or as part of the implementation.
const string Route = "Microsoft.AutoGen.Agents.IHandleFileIO";

dotnet/src/Microsoft.AutoGen/Agents/IOAgent/IProcessIO.cs:16

  • [nitpick] Static methods in interfaces are unusual and might not be intended. Consider removing the static modifier.
static Task ProcessOutputAsync(string message) { return Task.CompletedTask; }

dotnet/src/Microsoft.AutoGen/Agents/IOAgent/IProcessIO.cs:22

  • [nitpick] Static methods in interfaces are unusual and might not be intended. Consider removing the static modifier.
static Task<string> ProcessInputAsync(string message) { return Task.FromResult(message); }
@rysweet rysweet enabled auto-merge (squash) February 7, 2025 23:35
Copy link
Member

@lokitoth lokitoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛳️(ship) it

@rysweet rysweet merged commit edbd201 into main Feb 8, 2025
65 of 67 checks passed
@rysweet rysweet deleted the rysweet-grpc-service branch February 8, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants