Add get_thread method to BaseGroupChatManager and BaseGroupChat (Fixes #6085) - #8090
Open
MUKKTINAADH (mukktinaadh) wants to merge 1 commit into
Open
Add get_thread method to BaseGroupChatManager and BaseGroupChat (Fixes #6085)#8090MUKKTINAADH (mukktinaadh) wants to merge 1 commit into
MUKKTINAADH (mukktinaadh) wants to merge 1 commit into
Conversation
…microsoft#6085) - Add get_thread() method to BaseGroupChatManager to retrieve the current message thread - Add get_thread() method to BaseGroupChat that calls the manager via RPC - Both methods return a copy of the message thread for thread safety Fixes microsoft#6085
Contributor
|
MUKKTINAADH (@mukktinaadh) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
get_threadmethod to bothBaseGroupChatManagerandBaseGroupChatclasses to support retrieving the current message thread from a group chat team.Changes
BaseGroupChatManager.get_thread(): Added a new method that returns a copy of the current message thread (_message_thread). Returns a copy for thread safety.BaseGroupChat.get_thread(): Added a public method that retrieves the message thread from the group chat manager via RPC. The method:get_threadRPC method on the group chat managerUsage
Testing
Added basic verification that:
BaseGroupChatManager.get_thread()returns a copy of the message threadBaseGroupChat.get_thread()calls the manager via RPCFixes #6085