Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdi: Renaming binaries in the SPEC file to align with upstream naming conventions #12214

Open
wants to merge 1 commit into
base: 3.0-dev
Choose a base branch
from

Conversation

sharath-srikanth-chellappa
Copy link
Contributor

@sharath-srikanth-chellappa sharath-srikanth-chellappa commented Feb 4, 2025

The cdi binaries are misnamed in the SPEC file leading to additional Dockerfile commands to rename the binaries. Changing the SPEC file naming conventions to align with upstream and removing Dockerfile workarounds.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

The cdi binaries are misnamed in the SPEC file leading to additional Dockerfile commands to rename the binaries. Changing the SPEC file naming conventions to align with upstream and removing Dockerfile workarounds.

Change Log
Does this affect the toolchain?

NO

Associated issues
  • #56050776
Links to CVEs
Test Methodology
(base) sharath@sharath-2:~$ sudo trivy image  --exit-code 1 --severity HIGH,CRITICAL,MEDIUM "acrafoimages.azurecr.io/base/kubevirt/cdi-uploadserver:1.57.0-10.3.0.20250204-amd64" --ignore-unfixed --quiet
[sudo] password for sharath:

acrafoimages.azurecr.io/base/kubevirt/cdi-uploadserver:1.57.0-10.3.0.20250204-amd64 (azurelinux 3.0)

Total: 0 (MEDIUM: 0, HIGH: 0, CRITICAL: 0)

(base) sharath@sharath-2:~$ sudo trivy image  --exit-code 1 --severity HIGH,CRITICAL,MEDIUM "acrafoimages.azurecr.io/base/kubevirt/cdi-uploadproxy:1.57.0-10.3.0.20250204-amd64" --ignore-unfixed --quiet

acrafoimages.azurecr.io/base/kubevirt/cdi-uploadproxy:1.57.0-10.3.0.20250204-amd64 (azurelinux 3.0)

Total: 0 (MEDIUM: 0, HIGH: 0, CRITICAL: 0)

(base) sharath@sharath-2:~$ sudo trivy image  --exit-code 1 --severity HIGH,CRITICAL,MEDIUM "acrafoimages.azurecr.io/base/kubevirt/cdi-operator:1.57.0-10.3.0.20250204-amd64" --ignore-unfixed --quiet

acrafoimages.azurecr.io/base/kubevirt/cdi-operator:1.57.0-10.3.0.20250204-amd64 (azurelinux 3.0)

Total: 0 (MEDIUM: 0, HIGH: 0, CRITICAL: 0)

(base) sharath@sharath-2:~$ sudo trivy image  --exit-code 1 --severity HIGH,CRITICAL,MEDIUM "acrafoimages.azurecr.io/base/kubevirt/cdi-importer:1.57.0-10.3.0.20250204-amd64" --ignore-unfixed --quiet

acrafoimages.azurecr.io/base/kubevirt/cdi-importer:1.57.0-10.3.0.20250204-amd64 (azurelinux 3.0)

Total: 0 (MEDIUM: 0, HIGH: 0, CRITICAL: 0)

(base) sharath@sharath-2:~$ sudo trivy image  --exit-code 1 --severity HIGH,CRITICAL,MEDIUM "acrafoimages.azurecr.io/base/kubevirt/cdi-controller:1.57.0-10.3.0.20250204-amd64" --ignore-unfixed --quiet

acrafoimages.azurecr.io/base/kubevirt/cdi-controller:1.57.0-10.3.0.20250204-amd64 (azurelinux 3.0)

Total: 0 (MEDIUM: 0, HIGH: 0, CRITICAL: 0)

(base) sharath@sharath-2:~$ sudo trivy image  --exit-code 1 --severity HIGH,CRITICAL,MEDIUM "acrafoimages.azurecr.io/base/kubevirt/cdi-cloner:1.57.0-10.3.0.20250204-amd64" --ignore-unfixed --quiet

acrafoimages.azurecr.io/base/kubevirt/cdi-cloner:1.57.0-10.3.0.20250204-amd64 (azurelinux 3.0)

Total: 0 (MEDIUM: 0, HIGH: 0, CRITICAL: 0)

(base) sharath@sharath-2:~$ sudo trivy image  --exit-code 1 --severity HIGH,CRITICAL,MEDIUM "acrafoimages.azurecr.io/base/kubevirt/cdi-apiserver:1.57.0-10.3.0.20250204-amd64" --ignore-unfixed --quiet

acrafoimages.azurecr.io/base/kubevirt/cdi-apiserver:1.57.0-10.3.0.20250204-amd64 (azurelinux 3.0)

Total: 0 (MEDIUM: 0, HIGH: 0, CRITICAL: 0)

@sharath-srikanth-chellappa sharath-srikanth-chellappa requested a review from a team as a code owner February 4, 2025 17:13
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Feb 4, 2025
@romoh
Copy link
Contributor

romoh commented Feb 4, 2025

LGTM

Copy link
Contributor

@mandeepsplaha mandeepsplaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Can you please run a container build for the cdi components and ensure they build successfully, and can you also link the build run in the PR description?

@sharath-srikanth-chellappa
Copy link
Contributor Author

The changes look good. Can you please run a container build for the cdi components and ensure they build successfully, and can you also link the build run in the PR description?

Added that information to the PR description. Also added a manual trivy scan of the container images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants