Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify toolkit's build_go_vendor_cache.sh script to be used for most go packages #12217

Draft
wants to merge 4 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

mbykhovtsev-ms
Copy link
Contributor

@mbykhovtsev-ms mbykhovtsev-ms commented Feb 4, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

This script has not been used for a while and we started creating lots of of these scripts within packages them. But all of them share the same code and do the same thing. So this PR modifies this script to universally work for all go packages and allow it to be used by the upgrade tool

Change Log
  • Makes script use 4 input parameters like other scripts
  • Makes script use compression when creating tarball
  • Makes script output to specific folder provided by the inputs
Does this affect the toolchain?

NO

Test Methodology
  • Pipeline build id: xxxx

@microsoft-github-policy-service microsoft-github-policy-service bot added Tools 3.0-dev PRs Destined for AzureLinux 3.0 labels Feb 4, 2025
@@ -2,8 +2,92 @@
# Copyright (c) Microsoft Corporation.
# Licensed under the MIT License.

# Quit on failure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify that this isn't really used anymore so that we can take it over this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants