BinSkim .NET Updates to version 9 #1024
Conversation
AllDwarf
changed the title
AllDwarf
force-pushed
the
users/marekaldorf/BinSkim_dotnet_updates
branch
from
3d1696b to
990a79d
Compare
AllDwarf
force-pushed
the
users/marekaldorf/BinSkim_dotnet_updates
branch
2 times, most recently
from
8c0ae1d to
c90c64e
Compare
AllDwarf
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| catch (Exception ex) | ||
| { | ||
| throw new InvalidOperationException("Failed to read string from memory.", ex); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
AllDwarf
force-pushed
the
users/marekaldorf/BinSkim_dotnet_updates
branch
from
c72a5f2 to
0884878
Compare
| @@ -121,13 +121,18 @@ public ulong ReadLength(out bool is64bit) | |||
| /// <summary> | |||
| /// Reads the string from the current position in the stream. | |||
| /// </summary> | |||
| [HandleProcessCorruptedStateExceptions] | |||
There was a problem hiding this comment.
I may be reading the docs wrong, but with HandleProcessCorruptedStateExceptions being removed - are you still trying to catch CSEs with the try-catch block?
There was a problem hiding this comment.
well I went over the docs, and as of now the only option seems to be try catch, so I did it with the generic try catch clause. But I'm more than open to the suggestions for improvements :)
src/Directory.Packages.props
Outdated
There was a problem hiding this comment.
Nitpick: It seems there's a mix of major, minor and patch updates - I assume not all of them are strictly .NET update related (I'd be surprised if some of these patch level updates would be). I think it's fine to update dependencies in general, but too many changes here make it a bit tricky to review these. Separate PR in a regular dependency update cycle would be great in the future.
Enhance memory reading and COM object management with error handling and platform checks
Add static keyword to lambdas in AnalyzeCommandTests.cs
Modified lambda expressions in AnalyzeCommandTests.cs to be static.
This change ensures that the lambdas do not capture variables from
the enclosing scope, potentially improving performance and clarity.
Fixing version constant file
Refactor project to target .NET 9.0 and remove obsolete configurations
Update ADO build configuration to target .NET 9.0 and add .vscode to .gitignore
Update GitHub workflows to target .NET 9.0 and improve formatting steps
Update .gitignore and improve Build scripts for .NET 9.0 compatibility
Directory.Packages.props fixes
Fix formatting in VersionConstants.cs by removing unnecessary whitespace
Update ADO build configuration to allow all branches for PRs
Remove platform-specific exceptions in PDB handling for cross-platform support
Refactor platform-specific code and resource management
Removed `using System.Runtime.Versioning;` and `[SupportedOSPlatform("windows")]` from `MSDiaComWrapper.cs` and `Pdb.cs`. Replaced `Marshal.GetObjectForIUnknown` with `ResourceReleaser.GetObjectForIUnknown` in `MSDiaComWrapper.cs`. Removed `OperatingSystem.IsWindows()` checks in `Pdb.cs` and ensured `PlatformSpecificHelpers.ThrowIfNotOnWindows()` still enforces Windows-only execution in `Init` methods. Simplified codebase by removing redundant platform checks.
AllDwarf
force-pushed
the
users/marekaldorf/BinSkim_dotnet_updates
branch
from
53a1ae1 to
000e522
Compare
[WIP] BinSkim .NET Updates to version 9
Overview
This pull request focuses on updating the BinSkim project to incorporate the latest .NET updates. The goal is to ensure compatibility with the newest .NET features and improve overall performance and security.
Changes
Updated the project to target the latest .NET version.
Benefits
Enhanced Compatibility: Ensures that the BinSkim project is compatible with the latest .NET version, taking advantage of new features and improvements.
Testing
Verified that the project builds successfully with the latest .NET version.
Ran all existing tests to ensure no regressions were introduced.
Conducted manual testing to confirm that the functionality remains intact.
Additional Notes
If you encounter any issues or have questions about these updates, please feel free to reach out.