Show typing middleware bugfix #2220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrecuenco
commented
Mar 25, 2025
alexrecuenco
force-pushed
the
show_typing_middleware_bugfix
branch
from
1010ba5 to
afdbbf8
Compare
It doesn't stop sending activities, this commit is just the test showing the failure. Under TDD principles
alexrecuenco
force-pushed
the
show_typing_middleware_bugfix
branch
from
afdbbf8 to
c3e6628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1980
Description
The typing middleware creates a long running task that is not cleared
Specific Changes
Testing
The tests are added on the first commit.