Integrate bm #146
Open
Integrate bm #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ider-azurestackhci
Merge to ecf baseline
Location value is being provided instead of a group value.
* Use new moc package's providerid functions. Use the new `providerid.FormatProviderID` function in MOC package instead of manually formatting the provider ID. This also inherently adds support for bare-metal provider IDs. * go.mod updates
…rkaround Remove load balancer workaround for bare metal.
…mCleanup Pre-upstream cleanup
romoh
previously approved these changes
Aug 9, 2021
|
Should we drop BM changes out of v1alpha3? |
Not sure I understand the proposal here? |
Since at the time of upstreaming v1alpha4 is already present, should we include the BM changes into the v1alpha3 API of CAPH or just into v1alpha4. |
I would vote for v1apha4 unless there will be significant cost associated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on microsoft/moc-sdk-for-go#68 and microsoft/moc#84. Dependencies will need to be updated once the lower layer PRs are merged.