[Do Not Review] Implementing $includes operation with paging. #4810
Conversation
tarunmathew12
added
New Feature
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (address == null) | ||
| { | ||
| uriString = _linkGenerator.GetUriByRouteValues( | ||
| httpContext, | ||
| routeName, | ||
| routeValues, | ||
| scheme, | ||
| new HostString(host), | ||
| pathBase); | ||
| } | ||
| else | ||
| { | ||
| uriString = _linkGenerator.GetUriByAddress<RouteValuesAddress>( | ||
| httpContext, | ||
| address, | ||
| address.ExplicitValues, | ||
| address.AmbientValues, | ||
| scheme, | ||
| new HostString(host), | ||
| pathBase); | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
| if (!isIncludesOperation) | ||
| { | ||
| // TODO: should this case be ignored or throw an exception? The Hl7 doc says, we should ignore it in general. (https://www.hl7.org/fhir/R4/search.html#errors) | ||
| // throw new BadRequestException(string.Format(Core.Resources.InvalidContinuationToken, query.Item2, SupportedTotalTypes)); | ||
| } |
Check warning
Code scanning / CodeQL
Futile conditional Warning
| (SqlExpressionRewriterWithInitialContext<object>)(_schemaInformation.Current >= SchemaVersionConstants.PartitionedTables | ||
| ? StringOverflowRewriter.Instance | ||
| : LegacyStringOverflowRewriter.Instance)) |
Check warning
Code scanning / CodeQL
Useless upcast Warning
src/Microsoft.Health.Fhir.SqlServer/Features/Search/SqlServerSearchService.cs
Fixed
Show fixed
Hide fixed
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Why move this from API to Core?
| <data name="UnsupportedIncludesOperation" xml:space="preserve"> | ||
| <value>The '$includes' operation is not supported for CosmosDB data store.</value> |
There was a problem hiding this comment.
I think it should just be "The '$includes' operation is not supported". We don't tend to mention the DB type in our messages.
| MatchResourceTypeId = tid; | ||
| MatchResourceSurrogateIdMin = sid0; | ||
| MatchResourceSurrogateIdMax = sid1; | ||
| initialized = true; |
There was a problem hiding this comment.
Is an include CT valid without the two include values?
Description
This is the initial implementation of the $includes operation with paging.
Related issues
Addresses [issue #138967].
User Story 138967: Implement a new $include operation.
Testing
Manually tested. Automated tests being added.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)