Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Cosmos Direct Mode Connection Config #4816

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

mikaelweave
Copy link
Contributor

@mikaelweave mikaelweave commented Feb 10, 2025

Description

Exposes CosmosSDK direct connection configuration values for CosmosDB backed FHIR Servers.

Note - a value of null is what we are passing to the configuration via the builder for all of these configuration values today (except for enableTcpConnectionEndpointRediscovery which we explicitly set to true).
https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/Microsoft.Azure.Cosmos/src/Fluent/CosmosClientBuilder.cs#L445

CleanShot 2025-02-10 at 10 41 40

Related issues

AB#140094

Testing

Run code to confirm configuration flows from env variables to client creation.

default
CleanShot 2025-02-10 at 10 40 03

w/ overrides
CleanShot 2025-02-10 at 10 38 54

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave requested a review from a team as a code owner February 10, 2025 18:41
@mikaelweave mikaelweave added this to the 2Wk11 milestone Feb 10, 2025
@mikaelweave mikaelweave added Area-CosmosDB Area related to CosmosDB storage Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Open source This change is only relevant to the OSS code or release. Enhancement Enhancement on existing functionality. and removed Open source This change is only relevant to the OSS code or release. labels Feb 10, 2025
@mikaelweave mikaelweave merged commit 0606cc8 into main Feb 10, 2025
49 of 56 checks passed
@mikaelweave mikaelweave deleted the personal/mikaelw/add-cosmos-direct-config branch February 10, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CosmosDB Area related to CosmosDB storage Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Enhancement Enhancement on existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants