Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated topmenubar + related files + tests #1262

Open
wants to merge 1 commit into
base: features/ux
Choose a base branch
from
Open

Updated topmenubar + related files + tests #1262

wants to merge 1 commit into from

Conversation

jamelachahbar
Copy link
Contributor

🛠️ Description

Updated Top Menu Bar and related files to improve the experience.

Fixes #
#1261

📷 Screenshots

image

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@microsoft-github-policy-service microsoft-github-policy-service bot added Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed labels Jan 23, 2025
@jamelachahbar jamelachahbar added the Tool: Web app Web app to learn about and manage toolkit resources. label Jan 24, 2025
@jamelachahbar jamelachahbar added this to the Web app milestone Jan 24, 2025
@flanakin flanakin requested review from Ivanmtta and akiskips January 31, 2025 07:19
@arthurclares
Copy link
Collaborator

@Ivanmtta @akiskips Guys, is this one good to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flanakin flanakin flanakin approved these changes

@arthurclares arthurclares Awaiting requested review from arthurclares

@Ivanmtta Ivanmtta Awaiting requested review from Ivanmtta

@akiskips akiskips Awaiting requested review from akiskips

Assignees

@flanakin flanakin

@arthurclares arthurclares

Labels
Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Tool: Web app Web app to learn about and manage toolkit resources.
Projects
None yet
Milestone
Web app
Development

Successfully merging this pull request may close these issues.
3 participants
@jamelachahbar @arthurclares @flanakin