[dev-v5] Add checkbox component #3223
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoituron
requested changes
Jan 21, 2025
AClerbois
changed the title
AClerbois
force-pushed
the
users/aclerbois/dev-v5/fluentcheckbox
branch
3 times, most recently
from
d4d01fc to
a7bc5aa
Compare
dvoituron
requested changes
Jan 22, 2025
| if (HasLabel()) | ||
| { | ||
| // When the id is not provided, generate a unique id. This allow to use the label for. | ||
| Id ??= $"checkbox-{Identifier.NewId()}"; |
There was a problem hiding this comment.
It's not necessary to add a prefix. You can use Identifier.NewId().
If the developer wants to know where his component is, he can set a custom ID.
There was a problem hiding this comment.
Fixed in the next commit
| <FluentCheckbox Shape="@CheckboxShape.Square" Label="Square disabled checked" Disabled="true" Checked="true" /> | ||
| <FluentCheckbox Shape="@CheckboxShape.Circular" Label="Circular disabled checked" Disabled="true" Checked="true" /> | ||
|
|
||
| <FluentCheckbox Shape="@CheckboxShape.Square" Label="Square disabled unchecked" Disabled="true" Checked="false" /> |
There was a problem hiding this comment.
Please don't display all possibilities: check/uncheck... The user can click on it to display the different views. So only a Square and a Circular checkbox.
There was a problem hiding this comment.
Fixed in the next commit
dvoituron
requested changes
Jan 22, 2025
| * Wait for this PR to delete the code. | ||
| * https://github.com/microsoft/fluentui/pull/33144 | ||
| */ | ||
| export function ObserveAttributeChanges(element: HTMLElement): void { |
There was a problem hiding this comment.
You can remove this file and use the global function.
if (firstRender)
{
await JSRuntime.InvokeVoidAsync("Microsoft.FluentUI.Blazor.Utilities.Attributes.observeAttributeChange", Element, "indeterminate", "boolean", "", true); // Force to refresh the Checked when Indeterminate is updated.
await JSRuntime.InvokeVoidAsync("Microsoft.FluentUI.Blazor.Utilities.Attributes.observeAttributeChange", Element, "checked", "boolean");
}| } | ||
|
|
||
| result = null; | ||
| validationErrorMessage = "The provided value is not a valid boolean."; |
There was a problem hiding this comment.
When is it possible?
- Either the value has to be defined by us and if an error is detected we can throw an exception.
- Either this case is possible and we need to use the localisation engine (we cannot hardcode strings)
AClerbois
force-pushed
the
users/aclerbois/dev-v5/fluentcheckbox
branch
from
a3d905c to
7ffc94d
Compare
Updated CheckboxThreeStates.razor to include additional FluentCheckbox components and modify existing ones. Renamed variables and added new ones in the @code section. Modified OnInitializedAsync and SetCheckStateChangedAsync methods in FluentCheckbox.razor.cs to handle value changes more effectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps