Handling empty response TryReadStringArrayWithLengthHeader #1009
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can run "dotnet format" and commit the result to pass the formatter. |
|
@prvyk Thanks, I've updated it. I created the PR by editing in github itself, not sure why the extra line crept up. |
vazois
requested changes
Feb 11, 2025
vazois
requested changes
Feb 13, 2025
| @@ -354,6 +354,22 @@ public async Task CanUseSetNxStringResultAsync() | |||
| ClassicAssert.AreEqual("Hello", resultMykey); | |||
| } | |||
|
|
|||
| [Test] | |||
| public async Task ShouldNotThrowExceptionForEmptyArrayResponse() | |||
There was a problem hiding this comment.
Can you resolve the warning here?
There was a problem hiding this comment.
Kept the async pattern to match pattern in rest of the tests. Used async connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1008