fix: remove redundant strings.ToLower in onerrorCommand#703
Open
dlevy-msft-sql wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: remove redundant strings.ToLower in onerrorCommand#703dlevy-msft-sql wants to merge 2 commits intomicrosoft:mainfrom
dlevy-msft-sql wants to merge 2 commits intomicrosoft:mainfrom
Conversation
strings.EqualFold is already case-insensitive, making the ToLower call unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The onerrorCommand function has redundant code that makes the codebase harder to read.
Root Cause
strings.EqualFold is already case-insensitive, so wrapping the first argument with strings.ToLower() is unnecessary.
Code Change
Before:
After:
Testing
go build ./...TestOnErrorCommandpasses with live database connection (10.0.0.8)