Skip to content

Commit

Permalink
Make SK text and embedding generator wrappers public (#808)
Browse files Browse the repository at this point in the history
Currently it's possible to inject Semantic Kernel classes into KM only
using

- IKernelMemoryBuilder.WithSemanticKernelTextGenerationService
- IKernelMemoryBuilder.WithSemanticKernelTextEmbeddingGenerationService
- IServiceCollection.AddSingleton<ITextGenerator>(instance)
- IServiceCollection.AddSingleton<ITextEmbeddingGenerator>(instance)

However, it's not possible to create an instance of Semantic Kernel
classes directly without writing a custom wrapper class first. Since the
project already includes such wrapper, as internal classes, this PR
changes them to public classes, to reduce the amount of code to write.

Classes:
- SemanticKernelTextGenerator
- SemanticKernelTextEmbeddingGenerator
  • Loading branch information
dluc authored Sep 27, 2024
1 parent dc0deb5 commit 0d3e6f4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

namespace Microsoft.KernelMemory.SemanticKernel;

internal sealed class SemanticKernelTextEmbeddingGenerator : ITextEmbeddingGenerator
public sealed class SemanticKernelTextEmbeddingGenerator : ITextEmbeddingGenerator
{
private readonly ITextEmbeddingGenerationService _service;
private readonly ITextTokenizer _tokenizer;
Expand Down
2 changes: 1 addition & 1 deletion service/Core/SemanticKernel/SemanticKernelTextGenerator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace Microsoft.KernelMemory.SemanticKernel;

internal sealed class SemanticKernelTextGenerator : ITextGenerator
public sealed class SemanticKernelTextGenerator : ITextGenerator
{
private readonly ITextGenerationService _service;
private readonly ITextTokenizer _tokenizer;
Expand Down

0 comments on commit 0d3e6f4

Please sign in to comment.