Allow passing custom HttpClient #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
For some businesses and their teams, there is often a need for more detailed and personalized configuration when using HttpClient to make network requests. Semantic Kernel already supports this. However, inconsistencies in operation were found when using Semantic Kernel and Kernel Memory synchronously. To address this issue, this improvement PR has been submitted, aiming to standardize the corresponding features to be on par with the design of Semantic Kernel. Reference: microsoft/semantic-kernel#743
Description
Introduce a new optional parameter named
httpClient. By setting its default value tonull, we ensure that the existing user's code remains unaffected and backward compatible.