Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding contentType to document #473

Merged
merged 4 commits into from
May 11, 2024

Conversation

pradeepr-roboticist
Copy link
Contributor

Motivation and Context (Why the change? What's the scenario?)

This addresses #471.

High level description (Approach, Design)

I just added a contentType to the document. Seems to fix some problems I faced with #471.

@pradeepr-roboticist pradeepr-roboticist requested a review from dluc as a code owner May 10, 2024 01:37
Copy link
Collaborator

@dluc dluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would use mime detection though, it's free :-)

@pradeepr-roboticist pradeepr-roboticist requested a review from dluc May 10, 2024 04:01
@pradeepr-roboticist pradeepr-roboticist requested a review from dluc May 10, 2024 13:22
@dluc
Copy link
Collaborator

dluc commented May 11, 2024

hi @pradeepr-roboticist the PR is ready for merge, only pending CLA, see the comment above. Thanks!

@pradeepr-roboticist
Copy link
Contributor Author

please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree

@pradeepr-roboticist
Copy link
Contributor Author

hi @pradeepr-roboticist the PR is ready for merge, only pending CLA, see the comment above. Thanks!

Just agreed to CLA. Thanks for the quick review!

@dluc dluc merged commit 6b0d347 into microsoft:main May 11, 2024
2 checks passed
@pradeepr-roboticist pradeepr-roboticist deleted the fix_issue_471 branch May 11, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants