-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding contentType to document #473
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I would use mime detection though, it's free :-)
hi @pradeepr-roboticist the PR is ready for merge, only pending CLA, see the comment above. Thanks! |
@microsoft-github-policy-service agree |
Just agreed to CLA. Thanks for the quick review! |
Motivation and Context (Why the change? What's the scenario?)
This addresses #471.
High level description (Approach, Design)
I just added a
contentType
to the document. Seems to fix some problems I faced with #471.