Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alef/newmerge #482

Closed
wants to merge 6 commits into from
Closed

Conversation

afederici75
Copy link
Contributor

Motivation and Context (Why the change? What's the scenario?)

-Ported additional tests from FML's original repo
-Added Elasticsearch support for TestMemoryFilters and TestCosineSimilarity

High level description (Approach, Design)

Changes in Elasticsearch:

-Removed all Free Mind Labs, Inc. copyright in both extension and test project.
-Refactored IndexNameHelper and turned it into a static class.
-Adjusted ElasticsearchMemoryDb to the changes in IndexNameHelper.	

Elasticsearch.UnitTests

-Removed Usings.cs
-Created MemoryDbFunctionalTest which descends from KM's BaseFunctionalTestCase, thus providing access to configuration and other common things.
-Refactored all tests to inherit from MemoryDbFunctionalTest and be consitent with KM's.	
-I had to remove my additional SearchTests. The changes I made to 

All Elasticsearch tests pass:
-DefaultTests (11)
-Additional (35)

Microsoft.KM.Core.Functional.... tests pass:
-TestMemoryFilters
-TestCosineSimilarity

@afederici75 afederici75 requested a review from dluc as a code owner May 13, 2024 19:58
@dluc
Copy link
Collaborator

dluc commented May 16, 2024

superseeded by #494

@dluc dluc closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants