Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Server improvements to asynchronous code #502

Merged
merged 2 commits into from
May 19, 2024
Merged

Conversation

dluc
Copy link
Collaborator

@dluc dluc commented May 18, 2024

Improve some areas of the SqlServer memory connector:

  • avoid I/O in ctor, which could cause the service to crash with dependency injection errors. Run the initialization logic on the first call to any public method instead.
  • change methods using I/O from sync to async
  • use async dispose for connection, command, and data reader instances
  • add missing ConfigureAwait(false) on instances async disposing logic

@dluc
Copy link
Collaborator Author

dluc commented May 18, 2024

/cc @kbeaugrand

@dluc dluc changed the title Various improvements to asynchronous code SQL Server improvements to asynchronous code May 18, 2024
@dluc dluc merged commit e0cc32c into microsoft:main May 19, 2024
6 checks passed
@dluc dluc deleted the ssasync branch May 19, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants