Add support for Dependency Injection with ITextEmbeddingGenerator #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dluc
reviewed
May 20, 2024
dluc
added
the
waiting for author
dluc
approved these changes
May 21, 2024
dluc
pushed a commit
that referenced
this pull request
May 27, 2024
## Motivation and Context (Why the change? What's the scenario?) Allow to inject IMemoryDb types, without the need to build an instance. Related to #503, it allows to register an `IMemoryDb` using Dependency Injection.
sangar-1028
added a commit
to sangar-1028/kernel-memory
that referenced
this pull request
Oct 21, 2024
## Motivation and Context (Why the change? What's the scenario?) Allow to inject IMemoryDb types, without the need to build an instance. Related to microsoft/kernel-memory#503, it allows to register an `IMemoryDb` using Dependency Injection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context (Why the change? What's the scenario?)
See #334. This PR replaces #444 so that it excludes unnecessary changes.