feat: batched graph construction that also support GPU#138
Open
yanghan234 wants to merge 13 commits intomainfrom
Open
feat: batched graph construction that also support GPU#138yanghan234 wants to merge 13 commits intomainfrom
yanghan234 wants to merge 13 commits intomainfrom
Conversation
Collaborator
Author
|
By running the benchmark script on the following structures: test_structures.xyz.zip, you should be able to see the following results: Also, the difference of the energy prediction and the time speedup are shown as plots: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
This PR implements a batched graph generation pipeline that supports GPU acceleration, alongside general code cleanup and refactoring.
Key Changes
BatchGraphConverterinconverter.py. This new converter leverages batch processing and can utilize CUDA for faster graph construction.threebody_indices_torch.pyto compute three-body indices efficiently on the GPU, replacing the CPU-bound iteration.build_dataloaderbuild_dataloaderinbuild.pyto support the new pipeline.batch_converterflag (default: True) to easily switch between the new optimized batch converter and the legacy single-item converter.pyproject.tomlto includetorch-scatterand refinetorchversion.scripts/benchmark_graph_converter.pyto benchmark and compare the speed of the new graph implementation