Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emmet-core down-pin causing ecosystem clash #61

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

janosh
Copy link
Contributor

@janosh janosh commented Dec 7, 2024

the down-pin on emmet-core causes incompatibility with atomate2 in materialsproject/atomate2#1079:

 × No solution found when resolving dependencies:
  ╰─▶ Because mattersim==1.0.0rc9 depends on emmet-core<0.84 and
      atomate2[strict-forcefields]==0.0.1 depends on mattersim==1.0.0rc9,
      we can conclude that atomate2[strict-forcefields]==0.0.1 depends on
      emmet-core<0.84.
      And because atomate2==0.0.1 depends on emmet-core>=0.84.3rc3, we can
      conclude that atomate2[strict-forcefields]==0.0.1 is incompatible.
      And because only atomate2[strict-forcefields]==0.0.1 is available and
      you require atomate2[strict-forcefields], we can conclude that your
      requirements are unsatisfiable.

this PR changes the max-version to a min-version for emmet-core and removes all strict pins (== -> >=) to make mattersim more flexible and less likely to clash with other packages

@yanghan234
Copy link
Collaborator

Thank you, @janosh. I will test to see if this causes any conflicts in our repository. Please stay tuned.

@yanghan234 yanghan234 self-requested a review December 23, 2024 03:49
@yanghan234 yanghan234 merged commit b340f4f into microsoft:main Dec 23, 2024
5 checks passed
@janosh
Copy link
Contributor Author

janosh commented Dec 23, 2024

Thanks for merging! Could we get a new release to unblock atomate2 integration?

@yanghan234
Copy link
Collaborator

Hi @janosh, I just released a release candidate. Please try it in atomate2 and see if it works now. Let me know if further modification is needed.

janosh added a commit to materialsproject/atomate2 that referenced this pull request Dec 23, 2024
@janosh
Copy link
Contributor Author

janosh commented Dec 23, 2024

thanks @yanghan234. looks like the RC solved the issue. 👍

there's still an incompatibility with mace-torch but i think that needs to be solved on the MACE side. pinging @ilyes319 to suggest a mace-torch release that relaxes the e3nn pin to e3nn>=0.4.4

  × No solution found when resolving dependencies:
  ╰─▶ Because mace-torch>=0.3.6 depends on e3nn==0.4.4 and only the following
      versions of mace-torch are available:
          mace-torch<=0.3.6
          mace-torch==0.3.7
          mace-torch==0.3.8
          mace-torch==0.3.9
      we can conclude that mace-torch>=0.3.6 depends on e3nn==0.4.4.
      And because mattersim==1.0.1rc1 depends on e3nn>=0.5.0, we can conclude
      that mace-torch>=0.3.6 and mattersim==1.0.1rc1 are incompatible.

@yanghan234 yanghan234 mentioned this pull request Dec 30, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants