Fix static build with CMAKE_DEBUG_POSTFIX #5656
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
guhetier
reviewed
Dec 16, 2025
| endif() | ||
| else() | ||
| add_library(msquic_static STATIC static/empty.c) | ||
| set_target_properties(msquic_static PROPERTIES OUTPUT_NAME "${QUIC_LIBRARY_NAME}${CMAKE_DEBUG_POSTFIX}") |
Collaborator
There was a problem hiding this comment.
The bug / PR description mentions the issue when QUIC_BUILD_SHARED=ON, but this is in the QUIC_BUILD_SHARED=OFF path. A similar change might be needed above to add the postfix
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5656 +/- ##
==========================================
- Coverage 85.05% 84.25% -0.80%
==========================================
Files 60 60
Lines 18663 18663
==========================================
- Hits 15873 15725 -148
- Misses 2790 2938 +148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes an issue where building a static version of msquic with
CMAKE_DEBUG_POSTFIXset fails during the linking step. Previously, the build would attempt to link a library file without the postfix, causing a fatal LNK1181 error. This change ensures the correct filename with the postfix is used for static builds.Steps to reproduce
QUIC_BUILD_SHARED=ONandCMAKE_DEBUG_POSTFIX=d.Expected behavior
The build should succeed using the correct library filename with the debug postfix.
Actual behavior
The build fails during linking because the library file without the postfix is referenced.
Notes
CMAKE_<CONFIG>_POSTFIXfor static builds.