-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MdePkg: Add Google Mock Library for BaseMemoryLib #1289
MdePkg: Add Google Mock Library for BaseMemoryLib #1289
Conversation
@apop5 and @VivianNK, PR of edk2: tianocore/edk2#10810 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #1289 +/- ##
==============================================
- Coverage 1.52% 1.42% -0.11%
==============================================
Files 1383 1383
Lines 359247 359091 -156
Branches 5524 5524
==============================================
- Hits 5493 5122 -371
- Misses 353466 353498 +32
- Partials 288 471 +183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Does a MockBaseMemoryLib actually make sense? The functions inside of base memory lib all operate on pointers that are passed into the functions. They don't independently access memory outside of what is passed in. Given the host based unit test functions this is targeting, I don't see why the actual basememory lib instance cannot be used? Am I missing anything? |
@SeolforHsieh can you confirm that the test you are writing can use the BaseMemoryLib? |
Description
Added MockBaseMemoryLib to be used by Googletests
How This Was Tested
Added MockBaseMemoryLib to GoogleTests and able to successfully include its functions
Integration Instructions
N/A