Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN EP] Use NCHW as preferred layout for DML backend #16037

Merged
merged 1 commit into from
May 25, 2023
Merged

[WebNN EP] Use NCHW as preferred layout for DML backend #16037

merged 1 commit into from
May 25, 2023

Conversation

Honry
Copy link
Contributor

@Honry Honry commented May 22, 2023

To improve performance on DML backend.

@Honry
Copy link
Contributor Author

Honry commented May 22, 2023

@guschmue, @fdwr, PTAL, thanks!

fdwr
fdwr reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Wanming. Please verify this line 'scales_hw = {scales[1], scales[2]};', but otherwise approved. The other comments are considerations.

@guschmue
Copy link
Contributor

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@guschmue
Copy link
Contributor

@Honry, lgtm. Waiting for CI and Dwayne to be happy.

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,ONNX Runtime Web CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@guschmue guschmue merged commit 0d1a8cc into microsoft:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdwr fdwr fdwr approved these changes

@guschmue guschmue guschmue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Honry @guschmue @fdwr