Update package.json to make the dist avaliable again #23991
+2,095
−944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchen351
commented
Mar 11, 2025
js/react_native/package.json
Outdated
| "bootstrap": "npm run pack-common && npm run unpack-common && npm run pack-libs && npm run unpack-libs && npm run e2e && npm run pods", | ||
| "test": "jest", | ||
| "pack-common": "cd ../common && npm pack && mv -f onnxruntime-common-*.tgz ../react_native/e2e/onnxruntime-common.tgz", | ||
| "unpack-common": "cd e2e && npm install --no-save ./onnxruntime-common.tgz", | ||
| "unpack-common": "cd e2e && npm install ./onnxruntime-common.tgz", |
There was a problem hiding this comment.
npm install --no-save doesn't update package-lock.json nor package.json
jchen351
commented
Mar 12, 2025
| "dependencies": { | ||
| "buffer": "^6.0.3" | ||
| }, | ||
| "scripts": { | ||
| "typescript": "tsc --noEmit", | ||
| "bootstrap": "npm run pack-common && npm run unpack-common && npm run pack-libs && npm run unpack-libs && npm run e2e && npm run pods", | ||
| "prepare": "npx bob build", | ||
| "bootstrap-no-pods": "npm run pack-common && npm run unpack-common && npm run pack-libs && npm run unpack-libs && npm run e2e", |
There was a problem hiding this comment.
Create this script so both Android and iOS can use it.
jchen351
commented
Mar 12, 2025
| @@ -62,44 +61,7 @@ jobs: | |||
| targetFolder: $(Build.SourcesDirectory)/js/react_native/android/libs | |||
| displayName: Copy Android package to React Native directory | |||
|
|
|||
| - script: | | |||
There was a problem hiding this comment.
This has been moved to react-native-bootstrap-steps.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding back missing dist folder
Motivation and Context