Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test for RotaryEmbedding #24022

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fs-eire
Copy link
Contributor

@fs-eire fs-eire commented Mar 13, 2025

Description

the BaseTester::Run function signature is:

void BaseTester::Run(ExpectResult expect_result, const std::string& expected_failure_string,
                     const std::unordered_set<std::string>& excluded_provider_types,
                     const RunOptions* run_options,
                     std::vector<std::unique_ptr<IExecutionProvider>>* execution_providers,
                     ExecutionMode execution_mode,
                     const Graph::ResolveOptions& options);

Its behavior is:

  • if the parameter execution_providers is empty, it will try to aggregate all execution providers available in the build, and for each EP, create inference session and perform test.
  • if the parameter execution_providers is not empty, it will run a single inference session, use the passed-in execution_providers as session options and perform test.

The old code may put multiple EPs into single inference sessions, but at runtime there will be only one EP running the test. Specifically, WebGPU EP is after CPU EP in this case, so the test never run on WebGPU EP.

To reviewers: if you see a lot of changes, click the "setting" button next to the "Jump to",

image

and check the "Hide Whitespace" and load it again.

{4D60F676-35F4-4546-B8E1-E2F42411A9E6}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant