Petri: Powershell command builder for Hyper-V cmdlets #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarks
reviewed
Feb 8, 2025
petri/src/vm/hyperv/powershell.rs
Outdated
| @@ -237,35 +209,31 @@ pub struct CreateVhdArgs<'a> { | |||
|
|
|||
| /// Create a new VHD, mount, initialize, and format. Returns drive letter. | |||
| pub fn create_vhd(args: CreateVhdArgs<'_>) -> anyhow::Result<char> { | |||
There was a problem hiding this comment.
Should we delete this function? I'd rather we didn't make it easy to mount VHDs on the host, since that makes the tests impossible to run on Linux (for OpenVMM tests).
There was a problem hiding this comment.
Ok, it's not being used anyway since I switched to the vhd1 crate like you suggested.
jstarks
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the powershell commands used for hyper-v petri to use a builder. In the future, this could be split out into a separate crate.