chore: add encoded versions of IndexedDB key/value #34630
+131
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Feb 5, 2025
| @@ -96,7 +96,7 @@ it('should round-trip through the file', async ({ contextFactory }, testInfo) => | |||
| openRequest.onsuccess = () => { | |||
| const request = openRequest.result.transaction('store', 'readwrite') | |||
| .objectStore('store') | |||
| .put('foo', 'bar'); | |||
| .put({ name: 'foo', date: new Date(0) }, 'bar'); | |||
There was a problem hiding this comment.
I think we would also benefit from a test with key being an array with a binary blob inside (whatever MDN means by that), and from a test with an explicit keyPath. Can be a follow up.
This comment has been minimized.
This comment has been minimized.
Skn0tt
force-pushed
the
storagestate-encoded
branch
from
3da33e0 to
c6f5edc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"8 flaky37788 passed, 655 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #34591