Skip to content

chore: remove _react and _vue selectors #38263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove _react and _vue selectors #38263

wants to merge 1 commit into from
+195 −126

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Nov 18, 2025

When querying with _react or _vue, suggest an alternative locator instead.

The error looks like this:

    Error: locator.click: Error: "_react" selector is not supported: locator('_react=BookList') resolved to 1 element:
        1) <ol>…</ol> aka getByText('Pride and PrejudiceTo Kill a')

    Call log:
      - waiting for locator('_react=BookList')

@dgozman
chore: remove _react selector
84ce8d9 
When querying with `_react`, suggest an alternative locator instead.
@dgozman dgozman requested a review from yury-s November 18, 2025 11:46
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Test results for "MCP"

1 failed
❌ [chrome] › mcp/test-debug.spec.ts:233 › test_debug / evaluate x 2 @mcp-macos-15

2431 passed, 116 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Test results for "tests 1"

1 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`

40308 passed, 787 skipped

Merge workflow run.

yury-s
yury-s reviewed Nov 19, 2025
View reviewed changes
packages/playwright-core/src/server/frames.ts
} else if (element) {
log = ` locator resolved to ${visible ? 'visible' : 'hidden'} ${injected.previewNode(element)}`;
}
injected.checkDeprecatedSelectorUsage(info.parsed, elements);
Copy link
Member

@yury-s yury-s Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the same to query, queryCount etc methods too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-s yury-s yury-s left review comments

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dgozman @pavelfeldman @yury-s